Mir

Merge lp://qastaging/~alan-griffiths/mir/first-cut-at-lp1415321 into lp://qastaging/mir

  1. first-cut-at-lp1415321
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Work in progress
Proposed branch: lp://qastaging/~alan-griffiths/mir/first-cut-at-lp1415321
Merge into: lp://qastaging/mir
Diff against target: 284 lines (+65/-39)
12 files modified
src/client/CMakeLists.txt (+17/-2)
src/client/events/CMakeLists.txt (+2/-2)
src/client/input/CMakeLists.txt (+8/-12)
src/client/input/input_event.cpp (+1/-1)
src/client/symbols.map (+27/-0)
src/common/CMakeLists.txt (+0/-10)
src/common/sharedlibrary/CMakeLists.txt (+4/-1)
src/include/common/mir/logging/input_timestamp.h (+1/-5)
src/server/CMakeLists.txt (+2/-1)
src/server/graphics/nested/CMakeLists.txt (+0/-4)
tests/unit-tests/CMakeLists.txt (+2/-0)
tests/unit-tests/client/input/test_android_input_receiver.cpp (+1/-1)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/first-cut-at-lp1415321
Reviewer Review Type Date Requested Status
Chris Halse Rogers Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+252627@code.qastaging.launchpad.net

Commit message

common, client: move client library code into libmirclient

Description of the change

common, client: move client library code into libmirclient

This is a first cut - there is probably more tidy-up required. But offered up so that other eyes can help spot the opportunities.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2389
http://jenkins.qa.ubuntu.com/job/mir-ci/3196/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/1609
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/1608
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1563/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1193/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1563/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3196/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Chris Halse Rogers (raof) wrote :

Why is mir::Udev::* in mirclient now? That's used by the platform code, and not by the client at all AFAIK.

review: Needs Fixing
Reply
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Why is mir::Udev::* in mirclient now? That's used by the platform code, and
> not by the client at all AFAIK.

Because it was hidden in common/input.

Good catch. Thanks

Reply

Unmerged revisions

2389. By Alan Griffiths

Fix linker issues

2388. By Alan Griffiths

Move a bunch of client library code out of libmircommon

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches