Merge lp://qastaging/~alan-griffiths/mir/fix-1290345-part2 into lp://qastaging/mir
Proposed by
Alan Griffiths
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Cemil Azizoglu | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 3321 | ||||
Proposed branch: | lp://qastaging/~alan-griffiths/mir/fix-1290345-part2 | ||||
Merge into: | lp://qastaging/mir | ||||
Prerequisite: | lp://qastaging/~alan-griffiths/mir/fix-1290345-part1 | ||||
Diff against target: |
98 lines (+35/-7) 3 files modified
examples/server_example.cpp (+24/-2) examples/server_example_test_client.cpp (+11/-0) src/server/default_server_configuration.cpp (+0/-5) |
||||
To merge this branch: | bzr merge lp://qastaging/~alan-griffiths/mir/fix-1290345-part2 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Mir CI Bot | continuous-integration | Approve | |
Kevin DuBois (community) | Approve | ||
Cemil Azizoglu (community) | Approve | ||
Review via email:
|
Commit message
server: Don't set $MIR_SOCKET in the server process - it is confusing at best.
Description of the change
server: Don't set $MIR_SOCKET in the server process - it is confusing at best.
As described in the linked bug setting $MIR_SOCKET doesn't allow a server with "--no-file" to launch a client. So don't set it by default, and update the example code with a launch process that works.
To post a comment you must log in.
Note to reviewers:
USC sets $MIR_SOCKET for itself in usc::ExternalSp inner:: ensure_ running( ) before execlp().
Unity8 doesn't (as far as I or Gerry knows) launch clients directly.
So I don't think setting $MIR_SOCKET in the server process is useful to anyone.