Mir

Merge lp://qastaging/~alan-griffiths/mir/fix-1521930 into lp://qastaging/mir

  1. fix-1521930
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 3205
Proposed branch: lp://qastaging/~alan-griffiths/mir/fix-1521930
Merge into: lp://qastaging/mir
Diff against target: 36 lines (+13/-5)
2 files modified
CMakeLists.txt (+4/-5)
src/common/symbols.map (+9/-0)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/fix-1521930
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Daniel van Vugt Approve
Alberto Aguirre (community) Approve
Review via email: mp+280838@code.qastaging.launchpad.net

Commit message

Enable vptr checks for -fsanitize=undefined

Description of the change

Enable vptr checks for -fsanitize=undefined

This MP doesn't fix any of the reported problems, just fixes the ubsanitizer build

To post a comment you must log in.
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Works here. LGTM.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3204
http://jenkins.qa.ubuntu.com/job/mir-ci/5880/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5355
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4262
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5308
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/190/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/206
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/206/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/206
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/206/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5305
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5305/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7815
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26181
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/186
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/186/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-xenial-touch/42/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26180

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5880/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Benign failure -- broken infrastructure.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Otherwise cool.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches