Mir

Merge lp://qastaging/~alan-griffiths/mir/fix-1557446 into lp://qastaging/mir

  1. fix-1557446
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Rejected
Rejected by: Daniel van Vugt
Proposed branch: lp://qastaging/~alan-griffiths/mir/fix-1557446
Merge into: lp://qastaging/mir
Diff against target: 14 lines (+3/-6)
1 file modified
debian/mir-demos.examples (+3/-6)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/fix-1557446
Reviewer Review Type Date Requested Status
Daniel van Vugt Abstain
Cemil Azizoglu (community) Abstain
Mir CI Bot continuous-integration Needs Fixing
Alan Griffiths Needs Information
Kevin DuBois (community) Approve
Review via email: mp+289075@code.qastaging.launchpad.net

Commit message

examples: don't select a small, random set of example sources to package - grab them all (LP: #1557446)

Description of the change

examples: don't select a small, random set of example sources to package - grab them all

To post a comment you must log in.
Revision history for this message
Kevin DuBois (kdub) wrote :

looks good

review: Approve
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Ok

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

That will do it. But there's no Makefile, and the README which is meant to provide build instructions is inadequate. Do we care right now?

review: Needs Information
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> That will do it. But there's no Makefile, and the README which is meant to
> provide build instructions is inadequate. Do we care right now?

I don't know if we care. In fact I'm not sure what we gain by distributing the examples with source - it isn't as though the source is hard to get.

Providing a makefile is prone to things getting out if step again. We maintain our CMakeLists.txt file and might be able to make it run "standalone" (although its setup depends on the various of our cmake/* scripts which would also need packaging).

review: Needs Information
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3396
https://mir-jenkins.ubuntu.com/job/mir-ci/588/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/488/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/518
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/510
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/510
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/498/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/498/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/498
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/498/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/498
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/498/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/498/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/588/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

I'm for the alternative branch.

review: Abstain
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I like both branches equally.

review: Abstain

Unmerged revisions

3396. By Alan Griffiths

All the examples

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches