Mir

Merge lp://qastaging/~alan-griffiths/mir/fix-PromptSessionClientAPI.DISABLED_client_pid_is_associated_with_session into lp://qastaging/mir

  1. fix-PromptSessionClientAPI.DISABLED_client_pid_is_associated_with_session
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2586
Proposed branch: lp://qastaging/~alan-griffiths/mir/fix-PromptSessionClientAPI.DISABLED_client_pid_is_associated_with_session
Merge into: lp://qastaging/mir
Diff against target: 63 lines (+10/-7)
3 files modified
src/server/frontend/published_socket_connector.cpp (+5/-0)
tests/acceptance-tests/test_prompt_session_client_api.cpp (+4/-6)
tests/mir_test/popen.cpp (+1/-1)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/fix-PromptSessionClientAPI.DISABLED_client_pid_is_associated_with_session
Reviewer Review Type Date Requested Status
Chris Halse Rogers Approve
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) Approve
Alberto Aguirre (community) Approve
Review via email: mp+259486@code.qastaging.launchpad.net

Commit message

frontend, tests: fix the client credential capture for prompt sessions

Description of the change

frontend, tests: fix the client credential capture for prompt sessions

To post a comment you must log in.
Revision history for this message
Chris Halse Rogers (raof) wrote :

Seems sensible.

review: Approve
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

I've linked the bug and as soon as we have an arm package built I'll test it against the test case.

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

OK.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2582
http://jenkins.qa.ubuntu.com/job/mir-ci/3869/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/2526
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-wily-amd64-build/36/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/2474/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/25/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2474
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2474/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/5349/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20603

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3869/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Mako failure is a known CI glitch

The wily failure though is puzzling though:

6: [ RUN ] PromptSessionClientAPI.client_pid_is_associated_with_session
6: sh: 1: mir_demo_client_basic: not found

I need a closer look at how the test is launched in CI...

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Just making everyone aware: since this is marked as critical for "Canonical System Image" (i.e. Krillin), it'll need to be released to Vivid+Overlay within a day or two (21st is the cutoff).

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2584
http://jenkins.qa.ubuntu.com/job/mir-ci/3877/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/2536
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-wily-amd64-build/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/2484
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/33/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2484
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2484/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/5358
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20619

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3877/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Not (yet) sure what's going on here. Maybe wily got invalid vagrind suppressions?

Revision history for this message
Kevin DuBois (kdub) wrote :

okay

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Our old problem of valgrind errors propagating into child processes. (And some dubious code in a test helper that we'd not tripped over before.)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:2585
http://jenkins.qa.ubuntu.com/job/mir-ci/3880/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/2542
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-wily-amd64-build/52
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/2490
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/36
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/36/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2490
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2490/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/5362
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20633

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3880/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

66 + char const* get_argv(int index);

Would this be better as "std::string get_argv(int index);"?

Revision history for this message
Chris Halse Rogers (raof) wrote :

You might want to use mtf::executable_path() to get the base path for mir_demo_client_basic? That'll get you the absolute path you need to use.

Then you can drop the commandline_server changes.

review: Needs Fixing
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> You might want to use mtf::executable_path() to get the base path for
> mir_demo_client_basic? That'll get you the absolute path you need to use.
>
> Then you can drop the commandline_server changes.

OK, that has slightly different semantics, but ought to cover the use-cases.

Revision history for this message
Chris Halse Rogers (raof) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches