Mir

Merge lp://qastaging/~alan-griffiths/mir/fix-bug-1130259 into lp://qastaging/~mir-team/mir/trunk

Proposed by Alan Griffiths
Status: Merged
Approved by: Robert Ancell
Approved revision: no longer in the source branch.
Merged at revision: 525
Proposed branch: lp://qastaging/~alan-griffiths/mir/fix-bug-1130259
Merge into: lp://qastaging/~mir-team/mir/trunk
Diff against target: 842 lines (+387/-77)
17 files modified
include/server/mir/default_server_configuration.h (+3/-0)
include/server/mir/frontend/message_processor_report.h (+53/-0)
include/server/mir/frontend/null_message_processor_report.h (+43/-0)
include/server/mir/frontend/protobuf_ipc_factory.h (+2/-0)
include/server/mir/logging/message_processor_report.h (+53/-0)
include/test/mir_test_doubles/stub_ipc_factory.h (+6/-0)
src/server/default_server_configuration.cpp (+35/-4)
src/server/frontend/CMakeLists.txt (+1/-0)
src/server/frontend/binder_service.cpp (+10/-4)
src/server/frontend/null_message_processor_report.cpp (+41/-0)
src/server/frontend/protobuf_message_processor.cpp (+37/-16)
src/server/frontend/protobuf_message_processor.h (+7/-1)
src/server/frontend/protobuf_socket_communicator.cpp (+2/-1)
src/server/logging/CMakeLists.txt (+1/-0)
src/server/logging/message_processor_report.cpp (+75/-0)
src/server/logging/session_mediator_report.cpp (+1/-1)
tests/integration-tests/test_error_reporting.cpp (+17/-50)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/fix-bug-1130259
Reviewer Review Type Date Requested Status
Robert Ancell Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+154771@code.qastaging.launchpad.net

Commit message

frontend, logging, config: Connect the ProtobufMessageProcessor to the reporting infrastructure

Description of the change

frontend, logging, config: Connect the ProtobufMessageProcessor to the reporting infrastructure

This avoids the inappropriate messaging to stderr

This includes a really dumb MessageProcessorReport that I'll improve in a future MP.

(Basically I intend it to collect start time, any error and finish time information during each call and put out some stats at the end).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Code looks correct.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches