Mir

Merge lp://qastaging/~alan-griffiths/mir/fix-bug-1183659 into lp://qastaging/~mir-team/mir/trunk

  1. fix-bug-1183659
  2. Merge into trunk
Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 702
Proposed branch: lp://qastaging/~alan-griffiths/mir/fix-bug-1183659
Merge into: lp://qastaging/~mir-team/mir/trunk
Diff against target: 89 lines (+42/-9)
1 file modified
src/client/mir_client_library.cpp (+42/-9)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/fix-bug-1183659
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Alexandros Frantzis (community) Approve
Review via email: mp+165572@code.qastaging.launchpad.net

Commit message

client library: support multiple connections from one executable

Description of the change

client library: support multiple connections from one executable

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:704
http://jenkins.qa.ubuntu.com/job/mir-ci/624/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-raring-i386-build/753
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-raring-amd64-build/636
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-raring-amd64-ci/109
        deb: http://jenkins.qa.ubuntu.com/job/mir-raring-amd64-ci/109/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vm-ci-build/./distribution=precise,flavor=amd64/337

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-ci/624/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

Nit:

31 +std::mutex connection_guard;
32 +std::unordered_set<MirConnection*> connections;

No indentation.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:705
http://jenkins.qa.ubuntu.com/job/mir-ci/625/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-raring-i386-build/754
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-raring-amd64-build/637
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-raring-amd64-ci/110
        deb: http://jenkins.qa.ubuntu.com/job/mir-raring-amd64-ci/110/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vm-ci-build/./distribution=precise,flavor=amd64/338

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-ci/625/rebuild

review: Approve (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches