Mir

Merge lp://qastaging/~alan-griffiths/mir/hack-the-hack into lp://qastaging/mir

  1. hack-the-hack
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Rejected
Rejected by: Alan Griffiths
Proposed branch: lp://qastaging/~alan-griffiths/mir/hack-the-hack
Merge into: lp://qastaging/mir
Diff against target: 21 lines (+2/-2)
1 file modified
tools/setup-partial-armhf-chroot.sh (+2/-2)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/hack-the-hack
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Alan Griffiths Disapprove
Daniel van Vugt Needs Fixing
Robert Carr (community) Approve
Chris Halse Rogers Approve
Review via email: mp+197501@code.qastaging.launchpad.net

Commit message

tools: make the terrible cross-build setup script handle package files with URL encoded colon

Description of the change

tools: make the terrible cross-build script handle package files with URL encoded colon

To post a comment you must log in.
Revision history for this message
Chris Halse Rogers (raof) wrote :

Yeah, this is about as terrible as the surrounding code.

review: Approve
Revision history for this message
Robert Carr (robertcarr) :
review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Before this branch I get:
dpkg-deb: error: `libxau6_1.0.8-1_armhf.deb' is not a debian format archive

With this branch I get:
error: did not download expected file (libxdmcp6_1%3a1.1.1-1_armhf.deb). script is malformed!

So different, but still a failure.

review: Needs Fixing
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

There is a better way: https://code.launchpad.net/~raof/mir/hack-hack-hack-remove-a-hack/+merge/197581

review: Disapprove
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1267
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/482/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/349/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/346
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/208/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/211
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/211/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/482/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

1267. By Alan Griffiths

Hack around URI encoding of colon

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches