Mir

Merge lp://qastaging/~alan-griffiths/mir/make-endpoint-accessible-option into lp://qastaging/mir

make-endpoint-accessible-option
Merge into development-branch

Proposed by Alan Griffiths on 2015-02-03

Status:	Merged
Approved by:	Daniel van Vugt on 2015-02-05
Approved revision:	2290
Merged at revision:	2300
Proposed branch:	lp://qastaging/~alan-griffiths/mir/make-endpoint-accessible-option
Merge into:	lp://qastaging/mir
Diff against target:	70 lines (+17/-1) 4 files modified src/include/platform/mir/options/configuration.h (+1/-0) src/platform/options/default_configuration.cpp (+2/-0) src/platform/symbols.map (+8/-0) src/server/frontend/default_configuration.cpp (+6/-1)
To merge this branch:	bzr merge lp://qastaging/~alan-griffiths/mir/make-endpoint-accessible-option
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel van Vugt			Approve on 2015-02-05
PS Jenkins bot (community)	continuous-integration		Approve on 2015-02-04
Alan Griffiths			Abstain on 2015-02-04
Alberto Aguirre (community)			Approve on 2015-02-04
Kevin DuBois (community)			Approve on 2015-02-03
Andreas Pokorny (community)		2015-02-03	Approve on 2015-02-03
Review via email: mp+248379@code.qastaging.launchpad.net

Commit message

options: add a config option to "chmod a=rw <endpoint>" if exposed on filesystem

Description of the change

options: add a config option to "chmod a=rw <endpoint>" if exposed on filesystem

Revision history for this message

Andreas Pokorny (andreas-pokorny) wrote on 2015-02-03:

looks good

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-03:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2888/rebuild

review: Approve (continuous-integration)

Revision history for this message

Kevin DuBois (kdub) wrote on 2015-02-03:

okay overall, althoug I guess I like "globally-rw-file" over "arw-file". We might also want to control based on unix groups, and not need such broad permission

review: Approve

Revision history for this message

Alberto Aguirre (albaguirre) wrote on 2015-02-04:

OK, makes it convenient for devs.

review: Approve

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2015-02-04:

> okay overall, althoug I guess I like "globally-rw-file" over "arw-file". We
> might also want to control based on unix groups, and not need such broad
> permission

Well, the option could take a string we search for u|g|o|a - any votes?

--rw-file arg (=a) Make socket filename rw
(equivalent to chmod <arg>=rw)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2015-02-04:

> > okay overall, althoug I guess I like "globally-rw-file" over "arw-file". We
> > might also want to control based on unix groups, and not need such broad
> > permission
>
> Well, the option could take a string we search for u|g|o|a - any votes?
>
> --rw-file arg (=a) Make socket filename rw
> (equivalent to chmod <arg>=rw)

review: Needs Information

Revision history for this message

Chris Halse Rogers (raof) wrote on 2015-02-04:

I'm somewhat hesitant to introduce this; it's somewhat of a workaround for us not being able to run Mir in a window in X, which it looks like Cemil is actually going to do soon.

If we are going to introduce it, I think it should be as minimal as possible. I'd prefer “make utterly insecure socket” over “set security for socket”.

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2015-02-04:

> I'm somewhat hesitant to introduce this; it's somewhat of a workaround for us
> not being able to run Mir in a window in X,

Actually, no - it isn't a workaround. This is what one of our downstream projects (USC) does and I think it is likely useful for the system compositor case (where the protection is done by other means).

> which it looks like Cemil is actually going to do soon.
>
> If we are going to introduce it, I think it should be as minimal as possible.
> I'd prefer “make utterly insecure socket” over “set security for socket”.

That was my thinking too.

review: Abstain

Revision history for this message

Chris Halse Rogers (raof) wrote on 2015-02-04:

Wait, USC publishes a world-readable socket? Sadface.

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2015-02-04:

New functions need a new stanza, I think...

35 +++ src/platform/symbols.map 2015-02-03 13:54:49 +0000
36 @@ -103,6 +103,7 @@
37 mir::graphics::Renderable::transformation*;
38 mir::graphics::UserDisplayConfigurationOutput::extents*;
39 mir::graphics::UserDisplayConfigurationOutput::UserDisplayConfigurationOutput*;
40 + mir::options::arw_server_socket_opt*;

review: Needs Fixing

lp://qastaging/~alan-griffiths/mir/make-endpoint-accessible-option updated on 2015-02-04

2288. By Alan Griffiths on 2015-02-04: Separate new entry point into a new symbol map stanza
2289. By Alan Griffiths on 2015-02-04: merge lp:mir
2290. By Alan Griffiths on 2015-02-04: Fix spurious change