Mir

Merge lp://qastaging/~alan-griffiths/mir/migrate-client-authorization-test-to-mir-Server-API into lp://qastaging/mir

  1. migrate-client-authorization-test-to-mir-Server-API
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2013
Proposed branch: lp://qastaging/~alan-griffiths/mir/migrate-client-authorization-test-to-mir-Server-API
Merge into: lp://qastaging/mir
Prerequisite: lp://qastaging/~alan-griffiths/mir/some-acceptance-tests-use-mir-Server-API
Diff against target: 1001 lines (+446/-216)
14 files modified
include/server/mir/server.h (+10/-2)
server-ABI-sha1sums (+1/-1)
src/server/server.cpp (+10/-0)
src/server/symbols.map (+2/-0)
tests/acceptance-tests/test_client_authorization.cpp (+47/-91)
tests/acceptance-tests/test_client_library.cpp (+2/-21)
tests/acceptance-tests/test_prompt_session_client_api.cpp (+114/-98)
tests/include/mir_test_framework/headless_in_process_server.h (+36/-0)
tests/include/mir_test_framework/headless_test.h (+5/-0)
tests/include/mir_test_framework/interprocess_client_server_test.h (+58/-0)
tests/mir_test_framework/CMakeLists.txt (+2/-0)
tests/mir_test_framework/headless_in_process_server.cpp (+36/-0)
tests/mir_test_framework/headless_test.cpp (+8/-3)
tests/mir_test_framework/interprocess_client_server_test.cpp (+115/-0)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/migrate-client-authorization-test-to-mir-Server-API
Reviewer Review Type Date Requested Status
Alexandros Frantzis (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Alberto Aguirre (community) Approve
Review via email: mp+239829@code.qastaging.launchpad.net

Commit message

tests: migrate ClientCredsTestFixture and PromptSessionClientAPI to mir::Server API

Description of the change

tests: migrate ClientCredsTestFixture and PromptSessionClientAPI to mir::Server API

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2010
http://jenkins.qa.ubuntu.com/job/mir-ci/1927/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/2275
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/2282
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/2210
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/267/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1147
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1147/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3188
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15134

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/1927/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Failure is lp:1386646 - triggering rebuild in the hope of another data-point.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:2010
http://jenkins.qa.ubuntu.com/job/mir-ci/1928/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/2277
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/2284
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/2212
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/268
        deb: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/268/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1149
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1149/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3190
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15136

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/1928/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Cool more cleanup.

review: Approve
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

415 +// We need to fake the client_pid for the as that is used to identify sessions

"for the ? "

416 +class HookSessionCoordinator : public msh::SessionCoordinatorWrapper

Not sure what the name "HookSessionCoordinator" means.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2012
http://jenkins.qa.ubuntu.com/job/mir-ci/1939/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/2292
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/2299
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/2227
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/279/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1164
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1164/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3203
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15170

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/1939/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

8: [ FAILED ] ClientCredsTestFixture.session_authorizer_receives_pid_of_connecting_clients (782 ms)

Hmm. Looks like a double delete of mir::Server::Self::server_config

I have to think about how that could possibly happen...

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2013
http://jenkins.qa.ubuntu.com/job/mir-ci/1940/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/2293
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/2300
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/2228
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/280/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1165
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1165/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3204
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15171

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/1940/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:2014
http://jenkins.qa.ubuntu.com/job/mir-ci/1943/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/2296
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/2303
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/2231
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/283
        deb: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/283/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1168
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1168/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3206
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15178

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/1943/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Re-running the build that's been failing as this is clearly an intermittent detection:

http://s-jenkins.ubuntu-ci:8080/job/mir-utopic-amd64-ci/285/console

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Re-runs of previously failing build with -r 2017:

http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/287/console
http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/288/console

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:2017
http://jenkins.qa.ubuntu.com/job/mir-ci/1945/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/2298
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/2308
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/2233
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/286
        deb: http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/286/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1170
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-utopic-armhf/1170/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3208
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15182

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/1945/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Another couple of re-runs of previously failing build with -r 2017:

http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/296/
http://jenkins.qa.ubuntu.com/job/mir-utopic-amd64-ci/297/

(Although I think I found the cause I couldn't reproduce locally and am therefore appropriately paranoid.)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches