Mir

Merge lp://qastaging/~alan-griffiths/mir/nested-mir-can-hide-cursor into lp://qastaging/mir

  1. nested-mir-can-hide-cursor
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 3003
Proposed branch: lp://qastaging/~alan-griffiths/mir/nested-mir-can-hide-cursor
Merge into: lp://qastaging/mir
Prerequisite: lp://qastaging/~alan-griffiths/mir/tweak-cursor-configuration
Diff against target: 242 lines (+130/-68)
1 file modified
tests/acceptance-tests/test_nested_mir.cpp (+130/-68)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/nested-mir-can-hide-cursor
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+273537@code.qastaging.launchpad.net

Commit message

tests: Test to prove the nested server can hide the cursor

Description of the change

tests: Test to prove the nested server can hide the cursor

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3000
http://jenkins.qa.ubuntu.com/job/mir-ci/5168/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4312
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3219
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4254/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/212/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1322
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1322/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/212/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4255
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4255/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/6916/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23995
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/213/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5168/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Failure is lp:1502896

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3001
http://jenkins.qa.ubuntu.com/job/mir-ci/5176/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4320
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3227
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4262
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/220/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1330
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1330/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/220/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4263
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4263/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/6922
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24004
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/221/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5176/rebuild

review: Approve (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote :

nits, the rest lgtm:

+struct CursorImage : public mg::CursorImage
+public:
+struct CursorWrapper : public mg::Cursor
redundant 'public's

+ geom::Size size() const { return { 24, 24 }; }
+ connection, 24, 24, mir_pixel_format_argb_8888, mir_buffer_usage_software);
+ std::array<uint8_t, 4*8*24*24> data;

could have less repeating of '24' if we had a "int cursor_side_length{24}" somewhere.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3003
http://jenkins.qa.ubuntu.com/job/mir-ci/5190/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4337
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3244
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4279
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/237/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1344
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1344/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/237/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4280
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4280/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/6939
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24025
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/238/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5190/rebuild

review: Approve (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote :

lgtm, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches