Mir

Merge lp://qastaging/~alan-griffiths/mir/rework-test_client_library.cpp into lp://qastaging/mir

rework-test_client_library.cpp
Merge into development-branch

Proposed by Alan Griffiths on 2014-05-28

Status:	Work in progress
Proposed branch:	lp://qastaging/~alan-griffiths/mir/rework-test_client_library.cpp
Merge into:	lp://qastaging/mir
Diff against target:	1922 lines (+768/-1050) 3 files modified tests/acceptance-tests/CMakeLists.txt (+1/-0) tests/acceptance-tests/test_client_library.cpp (+641/-1050) tests/acceptance-tests/test_client_library_threads.cpp (+126/-0)
To merge this branch:	bzr merge lp://qastaging/~alan-griffiths/mir/rework-test_client_library.cpp
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-06-03
Kevin DuBois (community)		2014-05-28	Approve on 2014-06-02
Review via email: mp+221216@code.qastaging.launchpad.net

Commit message

tests: Move (most of) client library tests into a single process

Description of the change

tests: Move (most of) client library tests into a single process

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-28:

FAILED: Continuous integration, rev:1671
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/1751/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/366/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/367/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/364/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/270/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-armhf-ci/269/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1022/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1751/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~alan-griffiths/mir/rework-test_client_library.cpp updated on 2014-05-28

1672. By Alan Griffiths on 2014-05-28: Add missing file
1673. By Alan Griffiths on 2014-05-28: Simplify signal/thread tests in test_client_library_threads.cpp
1674. By Alan Griffiths on 2014-05-28: Simplify signal/thread tests in test_client_library_threads.cpp

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-28:

FAILED: Continuous integration, rev:1672
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/1755/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/371
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/372
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/369/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/274/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-armhf-ci/273
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-armhf-ci/273/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1030/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1755/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-28:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1759/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2014-05-28:

"/home/phablet/mir-testrunner/mir_install_packages.sh: line 10: apt-app-repository: command not found"

WTF?!

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-29:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1764/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-29:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1778/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2014-06-02:

It isn't obvious why copying HandleNoSignals from one file to another might cause this failure. Triggering rebuild to see if it is consistent.

lp://qastaging/~alan-griffiths/mir/rework-test_client_library.cpp updated on 2014-06-02

1675. By Alan Griffiths on 2014-06-02: merge lp:~mir-team/mir/development-branch

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-02:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1786/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2014-06-02:

> It isn't obvious why copying HandleNoSignals from one file to another might
> cause this failure. Triggering rebuild to see if it is consistent.

Hmm. Seems consistent but is CNR on my desktop.

Tweaking the code in the hope of seeing something illuminating.

lp://qastaging/~alan-griffiths/mir/rework-test_client_library.cpp updated on 2014-06-02

1676. By Alan Griffiths on 2014-06-02: Tweak test_client_library_threads.cpp in the hope of stumbling over what CI fails on

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-02:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1788/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-02:

FAILED: Continuous integration, rev:1676
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/1791/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-utopic-i386-build/421
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-utopic-amd64-build/422
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-utopic-touch/420/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-amd64-ci/310/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-armhf-ci/309
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-utopic-armhf-ci/309/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1168/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1791/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Kevin DuBois (kdub) wrote on 2014-06-02:

The build timeout should have been increased to 3h (although why it takes 2+h to build is another matter). retriggering

Revision history for this message

Kevin DuBois (kdub) wrote on 2014-06-02:

looks okay to me (a few places could use some spacing cleanups, but not enough to block). Tests look much nicer and less intimidating to write.

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-03:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1795/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2014-06-03:

> > It isn't obvious why copying HandleNoSignals from one file to another might
> > cause this failure. Triggering rebuild to see if it is consistent.
>
> Hmm. Seems consistent but is CNR on my desktop.
>
> Tweaking the code in the hope of seeing something illuminating.

Didn't help. Trying not changing that test *at all* on lp:~alan-griffiths/mir/rework-test_client_library.cpp-mk2.

Unmerged revisions

1676. By Alan Griffiths on 2014-06-02: Tweak test_client_library_threads.cpp in the hope of stumbling over what CI fails on
1675. By Alan Griffiths on 2014-06-02: merge lp:~mir-team/mir/development-branch
1674. By Alan Griffiths on 2014-05-28: Simplify signal/thread tests in test_client_library_threads.cpp
1673. By Alan Griffiths on 2014-05-28: Simplify signal/thread tests in test_client_library_threads.cpp
1672. By Alan Griffiths on 2014-05-28: Add missing file
1671. By Alan Griffiths on 2014-05-28: Tidy up remaining tests
1670. By Alan Griffiths on 2014-05-28: Tidy up some tests
1669. By Alan Griffiths on 2014-05-28: Move (most of) client library tests into a single process