Mir

Merge lp://qastaging/~alan-griffiths/mir/second-test-for-cursors-in-nested into lp://qastaging/mir

Proposed by Alan Griffiths
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 2995
Proposed branch: lp://qastaging/~alan-griffiths/mir/second-test-for-cursors-in-nested
Merge into: lp://qastaging/mir
Prerequisite: lp://qastaging/~alan-griffiths/mir/first-test-for-cursors-in-nested
Diff against target: 128 lines (+102/-2)
1 file modified
tests/acceptance-tests/test_nested_mir.cpp (+102/-2)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/second-test-for-cursors-in-nested
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Alexandros Frantzis (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Abstain
Review via email: mp+273064@code.qastaging.launchpad.net

Commit message

test: add a test for clients of nested servers setting the cursor image

Description of the change

test: add a test for clients of nested servers setting the cursor image

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Mmm. No cursors on mako?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

OK, so the wily builder prodstack-worker-med-0 doesn't have X cursors either.

I need a new plan.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) :
review: Abstain
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

[ 69%] Building CXX object tests/integration-tests/CMakeFiles/mir_integration_tests.dir/test_focus_selection.cpp.o
/mir/tests/acceptance-tests/test_nested_mir.cpp:560:14: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
        data{uint8_t(id)}

Rats! I want to be able to just run clang builds without hacking a vivid environment.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Cool.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches