Merge lp://qastaging/~alan-griffiths/miral/fix-focus-and-movement-by-window-type into lp://qastaging/miral
Proposed by
Alan Griffiths
| Status: | Merged |
|---|---|
| Approved by: | Gerry Boland |
| Approved revision: | 508 |
| Merged at revision: | 501 |
| Proposed branch: | lp://qastaging/~alan-griffiths/miral/fix-focus-and-movement-by-window-type |
| Merge into: | lp://qastaging/miral |
| Prerequisite: | lp://qastaging/~alan-griffiths/miral/more-surface-to-window-renaming |
| Diff against target: |
412 lines (+179/-40) 16 files modified
CMakeLists.txt (+1/-1) debian/changelog (+10/-3) debian/libmiral2.symbols (+3/-1) include/miral/toolkit/window_spec.h (+42/-6) include/miral/window_manager_tools.h (+3/-0) miral/basic_window_manager.cpp (+5/-0) miral/basic_window_manager.h (+2/-0) miral/symbols.map (+7/-0) miral/window_info.cpp (+4/-4) miral/window_management_trace.cpp (+11/-0) miral/window_management_trace.h (+2/-0) miral/window_manager_tools.cpp (+3/-0) miral/window_manager_tools_implementation.h (+1/-0) scripts/process_doxygen_xml.py (+9/-1) test/active_window.cpp (+38/-0) test/drag_active_window.cpp (+38/-24) |
| To merge this branch: | bzr merge lp://qastaging/~alan-griffiths/miral/fix-focus-and-movement-by-window-type |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gerry Boland (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[libmiral] Fix focus and movement rules for Input Method and Satellite windows
Description of the change
A careful reading of the spec[1] says that Input Method windows and Satellite windows should not get focus.
In fixing this it became apparent that WindowManagemen
That means we introduced a new ABI, so we also start on release 1.2 with the corresponding stanza.
[1] "An input aid is a surface that has permission to deliver keyboard or pointer input to the surface that has input focus. ... In all other respects, an input aid should behave the same as a satellite that is constantly reparented to whichever window has input focus."
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM