lp://qastaging/~albaguirre/mir/fix-1427976

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://qastaging/mir

Alberto Aguirre (community): Disapprove on 2015-03-05

Alan Griffiths: Needs Fixing on 2015-03-05

Alexandros Frantzis (community): Needs Fixing on 2015-03-05

Daniel van Vugt: Needs Fixing on 2015-03-05

PS Jenkins bot (community): Approve (continuous-integration) on 2015-03-04

Diff: 363 lines (+162/-23)

5 files modified

src/include/common/mir/semaphore_lock.h (+81/-0)
src/server/frontend/session_mediator.cpp (+22/-22)
src/server/frontend/session_mediator.h (+2/-1)
tests/unit-tests/CMakeLists.txt (+1/-0)
tests/unit-tests/test_semaphore_lock.cpp (+56/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1427976: SessionMediator locks mutexes in one thread and unlocks them in another

High

Fix Released

Link a bug report

Related blueprints

2361. By Alberto Aguirre on 2015-03-04

Avoid unlocking sesssion mutex in a different thread.

In some cases, SessionMediator needs to lock the session
while it waits for Surface::swap_buffers which may complete asynchronously on a different thread.
Since a std::mutex cannot be used for such purposes a SemaphoreLock type is introduced.

2360. By Alan Griffiths on 2015-03-03

examples, compositor, shell: integrate the logic for tracking output areas into library.

Approved by Kevin DuBois, Robert Carr, Alexandros Frantzis, PS Jenkins bot.

2359. By Daniel van Vugt on 2015-03-03

Preallocate RenderableList and use a more efficient container. Our primary use case of RenderableList knows its size in advance.

Approved by PS Jenkins bot, Robert Carr, Kevin DuBois, Alexandros Frantzis.

2358. By Chris Halse Rogers on 2015-03-03

Provide a Dispatchable from the InputPlatform.

We'll want to manually dispatch the input when clients get to do their own
event dispatch.

Approved by PS Jenkins bot, Kevin DuBois, Alexandros Frantzis, Andreas Pokorny, Robert Carr.

2357. By Robert Carr on 2015-03-02

Pretty print event input event action enum values.

Approved by PS Jenkins bot, Alberto Aguirre, Alan Griffiths, Alexandros Frantzis.

2356. By Kevin DuBois on 2015-03-02

android: post to the external display over MHL/Slimport when present.

Approved by PS Jenkins bot, Alexandros Frantzis, Alan Griffiths.

2355. By Alberto Aguirre on 2015-03-02

Use std::mutex instead of RecursiveReadWriteMutex for Fd and Timer glib sources.

Approved by Alan Griffiths, PS Jenkins bot.

2354. By Alexandros Frantzis on 2015-03-02

tests: Add tests for manipulating main loop registrations from within their own callback.

Approved by PS Jenkins bot, Alberto Aguirre, Alan Griffiths.

2353. By Alan Griffiths on 2015-03-02

examples: resizing a maximized surface respects anchors.

Approved by Alberto Aguirre, PS Jenkins bot, Alexandros Frantzis.

2352. By Andreas Pokorny on 2015-03-02

Adds mir::Flags to common headers.

mir::Flags is a utility to allow treating the type safe scoped enums as a set of masks or bit flags that can be combined in a type safe way. mir::Flags also works with normal enumerations. Additionally it provides utilities to print enumeration values as strings. For that purpose two variadic macros are provided.
.

Approved by Chris Halse Rogers, PS Jenkins bot, Cemil Azizoglu, Robert Carr.