Merge lp://qastaging/~albaguirre/mir/fix-1439549 into lp://qastaging/mir
Proposed by
Alberto Aguirre
| Status: | Merged |
|---|---|
| Approved by: | Alan Griffiths |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2469 |
| Proposed branch: | lp://qastaging/~albaguirre/mir/fix-1439549 |
| Merge into: | lp://qastaging/mir |
| Diff against target: |
396 lines (+186/-74) 1 file modified
src/utils/screencast.cpp (+186/-74) |
| To merge this branch: | bzr merge lp://qastaging/~albaguirre/mir/fix-1439549 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexandros Frantzis (community) | Approve | ||
| Alan Griffiths | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Use buffer_stream apis directly when possible in mirscreencast.
Some drivers do not produce correct content when using glReadPixels on a surface rendered by a different context. Attemp to access the buffer directly though the MirBufferStream API if possible; fallbacks to EGL if attempt fails.
Description of the change
Use buffer_stream apis directly when possible in mirscreencast.
Some drivers do not produce correct content when using glReadPixels on a surface rendered by a different context. Attemp to access the buffer directly though the MirBufferStream API if possible; fallbacks to EGL if attempt fails.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:2466
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://