Mir

Merge lp://qastaging/~albaguirre/mir/fix-1519998 into lp://qastaging/mir

  1. fix-1519998
  2. Merge into development-branch
Proposed by Alberto Aguirre
Status: Merged
Approved by: Alexandros Frantzis
Approved revision: no longer in the source branch.
Merged at revision: 3152
Proposed branch: lp://qastaging/~albaguirre/mir/fix-1519998
Merge into: lp://qastaging/mir
Diff against target: 291 lines (+118/-19)
4 files modified
include/client/mir_toolkit/mir_buffer_stream.h (+3/-0)
src/client/buffer_stream.cpp (+20/-8)
src/client/buffer_stream.h (+15/-7)
tests/unit-tests/client/test_client_buffer_stream.cpp (+80/-4)
To merge this branch: bzr merge lp://qastaging/~albaguirre/mir/fix-1519998
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Approve
Review via email: mp+278662@code.qastaging.launchpad.net

Commit message

client buffer stream: always signal wait handle and invoke callback even during creation errors

The wait handle given to the client should always be signaled and the client supplied callback must be invoked
even if the server fails to create the buffer stream.

Clients can use mir_buffer_stream_is_valid to determine if a buffer stream was created succesfully.

Description of the change

client buffer stream: always signal wait handle and invoke callback even during creation errors

The wait handle given to the client should always be signaled and the client supplied callback must be invoked
even if the server fails to create the buffer stream.

Clients can use mir_buffer_stream_is_valid to determine if a buffer stream was created succesfully.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3128
http://jenkins.qa.ubuntu.com/job/mir-ci/5674/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5039
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3945
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4986/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4986/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5674/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3128
http://jenkins.qa.ubuntu.com/job/mir-ci/5675/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5040
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3946
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4987/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4987/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5675/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3129
http://jenkins.qa.ubuntu.com/job/mir-ci/5687/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5059
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3965
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5006/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5006/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5687/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

+ std::unique_ptr<gp::Closure> closure{gp::NewCallback(this, &mcl::BufferStream::created, callback, context)};
...
+ closure.release();

This seems a bit awkward. I think it better to use gp::NewPermanentCallback and not need the release to avoid a double delete.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3130
http://jenkins.qa.ubuntu.com/job/mir-ci/5689/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5061
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3967
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5008
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/23/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/19/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/19/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5008
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5008/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7549
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25562
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/21/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5689/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> + std::unique_ptr<gp::Closure> closure{gp::NewCallback(this,
> &mcl::BufferStream::created, callback, context)};
> ...
> + closure.release();
>
> This seems a bit awkward. I think it better to use gp::NewPermanentCallback
> and not need the release to avoid a double delete.

I guess that's a mild "Needs Fixing"

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3131
http://jenkins.qa.ubuntu.com/job/mir-ci/5701/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5076
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3982
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5023
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/33/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/31
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/31/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/31
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/31/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5023
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5023/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7563
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25593
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/31/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5701/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

+ std::unique_ptr<google::protobuf::Closure> closure;

could be const

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3132
http://jenkins.qa.ubuntu.com/job/mir-ci/5720/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5108
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4014
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5056
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/55/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/49
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/49/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/49
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/49/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5056
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5056/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7591
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25638
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/53/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5720/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2194/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5120
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4026
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5068/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/28
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/28/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/28
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/28/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5068
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5068/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7601/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25657

review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

CI network failure, reapproving.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches