Mir

Merge lp://qastaging/~albaguirre/mir/fix-test-client-input-failures into lp://qastaging/mir

  1. fix-test-client-input-failures
  2. Merge into development-branch
Proposed by Alberto Aguirre
Status: Merged
Approved by: Alberto Aguirre
Approved revision: no longer in the source branch.
Merged at revision: 3186
Proposed branch: lp://qastaging/~albaguirre/mir/fix-test-client-input-failures
Merge into: lp://qastaging/mir
Diff against target: 48 lines (+20/-3)
1 file modified
tests/acceptance-tests/test_client_input.cpp (+20/-3)
To merge this branch: bzr merge lp://qastaging/~albaguirre/mir/fix-test-client-input-failures
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Daniel van Vugt Approve
Andreas Pokorny (community) Approve
Review via email: mp+280063@code.qastaging.launchpad.net

Commit message

tests: TestClientInput: fix race between sending a fake event and surface becoming ready to receive events

Description of the change

tests: TestClientInput: fix race between sending a fake event and surface becoming ready to receive events

To post a comment you must log in.
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3185
http://jenkins.qa.ubuntu.com/job/mir-ci/5800/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5243
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4149
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5191
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/127/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/129
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/129/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/129
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/129/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5191
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5191/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7720
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25905
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/125/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5800/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2249/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5249
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4155/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5198
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/83
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/83/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/83
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/83/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5198
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5198/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7723
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25915

review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

"6: [ RUN ] ClientLatency.throttled_input_rate_yields_lower_latency
6: [1449705449.168071] mirserver: Starting
6: [1449705449.168149] mirserver: Selected driver: dummy (version 0.19.0)
6: [1449705449.170028] mirserver: Initial display configuration:
6: [1449705449.170953] mirserver: Using software cursor
6: [1449705449.171309] mirserver: Selected input driver: stub-input (version: 0.19.0)
6: [1449705449.171343] mirserver: Mir version 0.19.0
6: /mir/tests/acceptance-tests/test_latency.cpp:259: Failure
6: Value of: observed_latency
6: Expected: is < 1.1
6: Actual: 1.15 (of type float)
6: [1449705451.380062] mirserver: Stopping
6: [ FAILED ] ClientLatency.throttled_input_rate_yields_lower_latency (2230 ms)
"

Failure is lp:1509291

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It's sounding good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2250/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5250
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4156/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5199
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/84
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/84/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/84
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/84/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5199
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5199/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7724
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25916

review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

"6: /mir/tests/acceptance-tests/test_nested_mir.cpp:549: Failure
6: Actual function call count doesn't match EXPECT_CALL(*mock_cursor, show(_))...
6: Expected: to be called once
6: Actual: never called - unsatisfied and active
6: [1449708539.438760] mirserver: Stopping
6: [1449708539.463858] mirserver: Stopping
6: [ FAILED ] NestedServer.animated_cursor_image_changes_are_forwarded_to_host (1116 ms)"

That's lp:1523621, unrelated to this branch.

I'm winning the CI fail lottery today... Let's try again.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches