Merge lp://qastaging/~albaguirre/mir/no-minimize-to-hidden-mapping into lp://qastaging/mir
Proposed by
Alberto Aguirre
| Status: | Merged |
|---|---|
| Approved by: | Alberto Aguirre |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2689 |
| Proposed branch: | lp://qastaging/~albaguirre/mir/no-minimize-to-hidden-mapping |
| Merge into: | lp://qastaging/mir |
| Diff against target: |
69 lines (+3/-12) 5 files modified
examples/server_example_canonical_window_manager.cpp (+1/-3) src/server/scene/basic_surface.cpp (+0/-2) src/server/shell/canonical_window_manager.cpp (+1/-3) tests/acceptance-tests/test_client_library.cpp (+1/-1) tests/unit-tests/scene/test_basic_surface.cpp (+0/-3) |
| To merge this branch: | bzr merge lp://qastaging/~albaguirre/mir/no-minimize-to-hidden-mapping |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Alan Griffiths | Approve | ||
| Alexandros Frantzis (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Avoid mapping minimize state to hidden state.
Instead fix BasicSurface changing visibility state internally when receiving mir_surface_
It is the window manager's responsibility to change the surface state not BasicSurface.
Description of the change
Avoid mapping minimize state to hidden state.
Instead fix BasicSurface changing visibility state internally when receiving mir_surface_
It is the window manager's responsibility to change the surface state not BasicSurface.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good.