lp://qastaging/~albaguirre/mir/server-improve-abi-compat-with-mirprotobuf

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp://qastaging/mir

Robert Carr (community): Approve on 2015-07-22

Alexandros Frantzis (community): Approve on 2015-07-22

Chris Halse Rogers: Approve on 2015-07-22

Daniel van Vugt: Abstain on 2015-07-22

PS Jenkins bot (community): Approve (continuous-integration) on 2015-07-21

Diff: 748 lines (+127/-122)

13 files modified

src/client/buffer_stream.cpp (+9/-9)
src/client/mir_connection.cpp (+12/-12)
src/client/mir_prompt_session.cpp (+7/-7)
src/client/mir_screencast.cpp (+5/-5)
src/client/mir_surface.cpp (+13/-13)
src/client/rpc/mir_protobuf_rpc_channel.cpp (+3/-3)
src/include/common/mir/make_protobuf_object.h (+2/-5)
src/protobuf/mir_protobuf.proto (+24/-23)
src/server/frontend/event_sender.cpp (+23/-22)
src/server/frontend/protobuf_message_processor.cpp (+11/-10)
src/server/frontend/protobuf_responder.cpp (+10/-6)
src/server/frontend/protobuf_responder.h (+1/-1)
src/server/frontend/socket_connection.cpp (+7/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2766. By Alberto Aguirre on 2015-07-21

server:: Allocate mir::protobuf objects on the heap through their factory methods.

Avoid allocating protobuf objects on the stack to avoid mismatched message definitions between
server and mirprotobuf library. This improves ABI compatiblity with future revisions of mirprotobuf.

2765. By Alberto Aguirre on 2015-07-21

Avoid class layout changes in protobuf generated code to keep ABI compatibility in libmirprotobuf

The protobuf compiler uses order of apperance (not sequence numbers) when generating classes and table offsets.
New message definitions also need to be delcared at the end of the file to avoid changes to some generated array index offsets.

2764. By Alberto Aguirre on 2015-07-21

Move make_protobuf_object as it will be needed on server side as well

2763. By Kevin DuBois on 2015-07-21

android: correct a scenario that caused a sporadic server shutdown on multimonitor unplug.
fixes: lp: #1474891. Fixes: https://bugs.launchpad.net/bugs/1474891.

Approved by PS Jenkins bot, Alexandros Frantzis, Chris Halse Rogers, Cemil Azizoglu.

2762. By Daniel van Vugt on 2015-07-21

Bump the graphics platform ABI to 4. We've broken it this series
in r2756 compared to the previous series (bzr diff -rbr0.14 ...),
and since the 0.14 series just moved to ABI level 3 to fix bugs
we need to be sure to keep the ABI in the 0.15 series higher than
that. Because r2756 introduces further changes making us
incompatible with graphics platform ABI 3 in the 0.14 series.
.

Approved by Alexandros Frantzis, Alan Griffiths, PS Jenkins bot.

2761. By Chris Halse Rogers on 2015-07-21

Fix a stupid typo in a test name that's started to annoy me.

Approved by PS Jenkins bot.

2760. By Daniel van Vugt on 2015-07-21

Revert the revert. I'm tired of arguing.

2759. By Daniel van Vugt on 2015-07-21

Revert r2758. It removed the useful part of the regression test
rendering it pointless. I will propose a better solution...

2758. By Chris Halse Rogers on 2015-07-21

Drop reliance on real-time for BufferQueue.scaled_queue_still_follows_dropping_policy.

Approved by PS Jenkins bot, Robert Carr, Alexandros Frantzis, Alan Griffiths.

2757. By Daniel van Vugt on 2015-07-20

BufferQueue: Ensure when the screen turns off, the frame dropping
policy remains active to keep waking up blocked client swap buffers
calls. Even after we've scaled the queue size down (LP: #1475120). Fixes: https://bugs.launchpad.net/bugs/1475120.

Approved by Alexandros Frantzis, Kevin DuBois, PS Jenkins bot.