Merge lp://qastaging/~alecu/ubuntuone-control-panel/use-webservices into lp://qastaging/~nataliabidart/ubuntuone-control-panel/trunk

Proposed by Alejandro J. Cura
Status: Merged
Approved by: Natalia Bidart
Approved revision: 14
Merged at revision: 6
Proposed branch: lp://qastaging/~alecu/ubuntuone-control-panel/use-webservices
Merge into: lp://qastaging/~nataliabidart/ubuntuone-control-panel/trunk
Diff against target: 747 lines (+437/-76)
11 files modified
integration/__init__.py (+19/-0)
integration/run-tests (+1/-1)
integration/test_dbus_client.py (+61/-12)
integration/test_dbus_service.py (+22/-1)
integration/test_webclient.py (+80/-20)
ubuntuone/controlpanel/__init__.py (+2/-0)
ubuntuone/controlpanel/backend.py (+27/-1)
ubuntuone/controlpanel/dbus_client.py (+36/-19)
ubuntuone/controlpanel/dbus_service.py (+14/-11)
ubuntuone/controlpanel/tests/test_backend.py (+94/-3)
ubuntuone/controlpanel/webclient.py (+81/-8)
To merge this branch: bzr merge lp://qastaging/~alecu/ubuntuone-control-panel/use-webservices
Reviewer Review Type Date Requested Status
Natalia Bidart Approve
Review via email: mp+37928@code.qastaging.launchpad.net

Commit message

The backend's infrastructure takes real shape

Description of the change

 * Use libsoup as http client
 * Get credentials from ussoc
 * Sign request with OAuth
 * Connect to the real webservice
 * Better testing all around
 * Use of Deferreds instead of very verbose callbacks (but no twisted reactor)
 * kill a testing-webserver twisty bug

To post a comment you must log in.
13. By Alejandro J. Cura

cleanup the cleanup_signals code

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Constants

DBUS_SSO_NAME = "com.ubuntu.sso"
DBUS_SSO_PATH = "/credentials"
DBUS_SSO_IFACE = "com.ubuntu.sso.ApplicationCredentials"
APP_NAME = "Ubuntu One"

should be replaced by ubuntu_sso.DBUS_* constants and ubunutone.clientdefs for APP_NAME.

review: Needs Fixing
14. By Alejandro J. Cura

use the DBus constants defined in ubuntu_sso

Revision history for this message
Natalia Bidart (nataliabidart) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches