Music Lens

Merge lp://qastaging/~alecu/unity-lens-music/envvars-override-urls into lp://qastaging/unity-lens-music

  1. envvars-override-urls
  2. Merge into trunk
Proposed by Alejandro J. Cura
Status: Merged
Approved by: Francis Ginther
Approved revision: 138
Merged at revision: 137
Proposed branch: lp://qastaging/~alecu/unity-lens-music/envvars-override-urls
Merge into: lp://qastaging/unity-lens-music
Diff against target: 195 lines (+73/-45)
5 files modified
src/Makefile.am (+1/-0)
src/musicstore-scope.vala (+4/-4)
src/ubuntuone-constants.vala (+66/-0)
src/ubuntuone-webservices.vala (+1/-41)
tests/unit/Makefile.am (+1/-0)
To merge this branch: bzr merge lp://qastaging/~alecu/unity-lens-music/envvars-override-urls
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski (community) Approve
Leo Arias (community) code review Approve
Review via email: mp+164792@code.qastaging.launchpad.net

Commit message

Allow overriding the urls that are opened from environment variables

Description of the change

Refactor UbuntuOne-related constants into a common file, and allow overriding the urls that are opened from environment variables.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity-lens-music-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-armhf-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-i386-ci/7

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-lens-music-ci/7/rebuild

review: Approve (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

You make me happy! :)

review: Approve (code review)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:138
http://jenkins.qa.ubuntu.com/job/unity-lens-music-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-i386-ci/8

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-lens-music-ci/8/rebuild

review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks fine.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-lens-music-autolanding/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-amd64-autolanding/3
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-armhf-autolanding/3/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-raring-i386-autolanding/3

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Jenkins config had an issue, it should be fixed now. Re-approving.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: