Music Lens

Merge lp://qastaging/~alecu/unity-lens-music/musicstore-purchase into lp://qastaging/~unity-team/unity-lens-music/libunity7-compatible

  1. musicstore-purchase
  2. Merge into libunity7-compatible
Proposed by Alejandro J. Cura
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 146
Merged at revision: 141
Proposed branch: lp://qastaging/~alecu/unity-lens-music/musicstore-purchase
Merge into: lp://qastaging/~unity-team/unity-lens-music/libunity7-compatible
Diff against target: 1017 lines (+402/-188)
9 files modified
configure.ac (+1/-0)
debian/changelog (+7/-2)
debian/control (+1/-0)
src/Makefile.am (+2/-1)
src/album.vala (+1/-0)
src/musicstore-collection.vala (+12/-0)
src/musicstore-scope.vala (+218/-4)
src/ubuntuone-webservices.vala (+94/-65)
tests/unit/test-ubuntuone-purchases.vala (+66/-116)
To merge this branch: bzr merge lp://qastaging/~alecu/unity-lens-music/musicstore-purchase
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot (community) continuous-integration Approve
Michal Hruby (community) Approve
Review via email: mp+154483@code.qastaging.launchpad.net

Commit message

- Use payment preview for music purchases (LP: #1154176).

Description of the change

Use the payment preview for music purchases in the musicstore scope.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:142
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-raring-amd64-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-music-libunity7-compatible-ci/3/rebuild

review: Approve (continuous-integration)
lp://qastaging/~alecu/unity-lens-music/musicstore-purchase updated
143. By Alejandro J. Cura

Remove FIXME comment

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:143
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-raring-amd64-ci/4

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-music-libunity7-compatible-ci/4/rebuild

review: Approve (continuous-integration)
lp://qastaging/~alecu/unity-lens-music/musicstore-purchase updated
144. By Alejandro J. Cura

Apply missing fixes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:144
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-raring-amd64-ci/5

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-music-libunity7-compatible-ci/5/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote :

329 + var cover_pixbuf = new Pixbuf.from_stream (cover_file.read ());

Doing a blocking read on an http connection before actually returning a preview is a very bad idea. Please move this elsewhere.

lp://qastaging/~alecu/unity-lens-music/musicstore-purchase updated
145. By Alejandro J. Cura

Don't set notification icon before it's needed

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:145
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-raring-amd64-ci/6

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-music-libunity7-compatible-ci/6/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote :

Better, thanks.

review: Approve
lp://qastaging/~alecu/unity-lens-music/musicstore-purchase updated
146. By Alejandro J. Cura

fixed pay url

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:146
http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-lens-music-libunity7-compatible-raring-amd64-ci/7

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-team-unity-lens-music-libunity7-compatible-ci/7/rebuild

review: Approve (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Online services QA gave its +1, let's get it merged

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: