Merge ~alemar99/maas:ip_addr_validation_power_params into maas:master
| Status: | Merged |
|---|---|
| Approved by: | Alessandro Marcolini |
| Approved revision: | 841aae0a41bc4bca25c1d3cb492073ddfeb3be15 |
| Merge reported by: | MAAS Lander |
| Merged at revision: | not available |
| Proposed branch: | ~alemar99/maas:ip_addr_validation_power_params |
| Merge into: | maas:master |
| Diff against target: |
701 lines (+381/-20) 24 files modified
src/maasserver/api/tests/test_machine.py (+33/-0) src/maasserver/clusterrpc/driver_parameters.py (+8/-1) src/maasserver/fields.py (+66/-0) src/maasserver/tests/test_fields.py (+122/-0) src/maasserver/websockets/handlers/tests/test_machine.py (+39/-0) src/provisioningserver/drivers/__init__.py (+5/-1) src/provisioningserver/drivers/pod/lxd.py (+6/-1) src/provisioningserver/drivers/pod/virsh.py (+6/-1) src/provisioningserver/drivers/power/amt.py (+6/-1) src/provisioningserver/drivers/power/apc.py (+6/-1) src/provisioningserver/drivers/power/dli.py (+6/-1) src/provisioningserver/drivers/power/eaton.py (+6/-1) src/provisioningserver/drivers/power/hmc.py (+6/-1) src/provisioningserver/drivers/power/hmcz.py (+6/-1) src/provisioningserver/drivers/power/ipmi.py (+6/-1) src/provisioningserver/drivers/power/moonshot.py (+6/-1) src/provisioningserver/drivers/power/msftocs.py (+6/-1) src/provisioningserver/drivers/power/openbmc.py (+6/-1) src/provisioningserver/drivers/power/recs.py (+6/-1) src/provisioningserver/drivers/power/redfish.py (+6/-1) src/provisioningserver/drivers/power/seamicro.py (+6/-1) src/provisioningserver/drivers/power/ucsm.py (+6/-1) src/provisioningserver/drivers/power/vmware.py (+6/-1) src/provisioningserver/drivers/power/wedge.py (+6/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Anton Troyanov | Approve | ||
| MAAS Lander | Approve | ||
|
Review via email:
|
|||
Commit message
fix: validate ip address in machine power config
Resolves LP:1839189
Description of the change
Add ip address validation for machine power configuration
Fix bug: 1839189
To validate the ip address field, the `GenericIPAddre
from Django forms is used, which provides validation both for IPv4 and
IPv6 addresses. For lxd and virsh power types, two custom fields have
been created.
A new field_type of value "ip_address" was added to the JSON spec to
handle this scenario and all the `make_setting_
have been updated consequently, except for virsh and lxd, which have
their specific field type because of the peculiarity of the address.
Because of this, changes in the UI are required, otherwise the new
field_type will not be handled by the UI. Nick has a branch on this
(https:/
which I have already tested and it works (as of now it only contains
changes regarding the field_type "ip_address").
| Alessandro Marcolini (alemar99) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
UNIT TESTS
-b ip_addr_
STATUS: FAILED
LOG: http://
COMMIT: 97ac1133dbeab13