Merge lp://qastaging/~alexhenrie24/gdebi/fix-mime-type into lp://qastaging/gdebi

Proposed by Alex Henrie
Status: Merged
Merged at revision: 487
Proposed branch: lp://qastaging/~alexhenrie24/gdebi/fix-mime-type
Merge into: lp://qastaging/gdebi
Diff against target: 53 lines (+7/-3)
4 files modified
GDebi/GDebiCommon.py (+1/-1)
data/gdebi-kde.desktop.in (+1/-1)
data/gdebi.desktop.in (+1/-1)
debian/changelog (+4/-0)
To merge this branch: bzr merge lp://qastaging/~alexhenrie24/gdebi/fix-mime-type
Reviewer Review Type Date Requested Status
Michael Vogt Approve
Dimitri John Ledkov Pending
Luca Falavigna Pending
gdebi-developers Pending
Review via email: mp+263322@code.qastaging.launchpad.net

Description of the change

xdg-open, used by Chromium and other applications, currently opens .deb files with /usr/lib/mime/debian-view instead of GDebi. It ignores GDebi because .deb files are detected as application/vnd.debian.binary-package, but gdebi.desktop only registers the nonstandard MIME types application/x-deb and application/x-debian-package. This is unfortunate because GDebi is far more user-friendly than debian-view.

I can't see a good reason to maintain support for the nonstandard MIME types. I think it would be best to drop them and instead register the MIME type that actually works.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a bunch! Its fine to remove the old mime-type, we might consider bringing it back if there are apps (like filemanagers) out there that use it to send it to gdebi. But for now I'm in favour of using only the real one. Thanks again!

review: Approve
Revision history for this message
Alex Henrie (alexhenrie24) wrote :

Thank you!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: