Do Plugins

Merge lp://qastaging/~alexlauni/do-plugins/twitter-api-fixes into lp://qastaging/do-plugins

  1. twitter-api-fixes
  2. Merge into trunk
Proposed by Alex Launi
Status: Merged
Merged at revision: not available
Proposed branch: lp://qastaging/~alexlauni/do-plugins/twitter-api-fixes
Merge into: lp://qastaging/do-plugins
Diff against target: None lines
To merge this branch: bzr merge lp://qastaging/~alexlauni/do-plugins/twitter-api-fixes
Reviewer Review Type Date Requested Status
Chris S. Approve
Review via email: mp+5645@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Launi (alexlauni) wrote :

Fixes breakage caused by twitter api changes.

Revision history for this message
Chris S. (cszikszoy) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Microblogging/src/MicroblogClient.cs'
2--- Microblogging/src/MicroblogClient.cs 2009-02-28 19:53:07 +0000
3+++ Microblogging/src/MicroblogClient.cs 2009-04-17 02:15:08 +0000
4@@ -45,9 +45,9 @@
5 readonly string FailedPostMsg = Catalog.GetString ("Unable to post tweet. Check your login settings. If you "
6 + "are behind a proxy make sure that the settings in /system/http_proxy are correct.");
7
8- const int UpdateTimelineTimeout = 30 * 1000;
9- const int UpdateContactsTimeout = 10 * 60 * 1000;
10- const int CheckForMessagesTimeout = 5 * 60 * 1000;
11+ const int UpdateTimelineTimeout = 60 * 1000; // every 60 seconds
12+ const int UpdateContactsTimeout = 30 * 1000 * 60; // every 30 minutes
13+ const int CheckForMessagesTimeout = 5 * 1000 * 60; // every 5 minutespr
14
15 #endregion
16
17@@ -121,6 +121,7 @@
18 newContacts = new List<FriendItem> ();
19 friends = blog.User.Friends ();
20 } catch (TwitterizerException e) {
21+ Log.Error("{0} {1}", e.RequestData.ResponseException.Message, e.RequestData.ResponseException.StackTrace);
22 Log<MicroblogClient>.Debug (GenericErrorMsg, "UpdateContacts", e.Message);
23 return;
24 }
25
26=== modified file 'Microblogging/src/Twitterizer/Twitterizer.Framework/MethodClasses/TwitterStatusMethods.cs'
27--- Microblogging/src/Twitterizer/Twitterizer.Framework/MethodClasses/TwitterStatusMethods.cs 2009-02-28 16:16:48 +0000
28+++ Microblogging/src/Twitterizer/Twitterizer.Framework/MethodClasses/TwitterStatusMethods.cs 2009-04-13 04:10:11 +0000
29@@ -109,7 +109,7 @@
30
31 string actionUri = (Parameters == null ? Twitter.Urls.FriendsTimelineUrl : Parameters.BuildActionUri(Twitter.Urls.FriendsTimelineUrl));
32 Data.ActionUri = new Uri(actionUri);
33-
34+
35 Data = Request.PerformWebRequest(Data);
36
37 return Data.Statuses;
38@@ -141,7 +141,7 @@
39 Data.ActionUri = new Uri(
40 string.Format(Twitter.Urls.UpdateUrl, HttpUtility.UrlEncode(Status), InReplyToStatusID));
41
42- Data = Request.PerformWebRequest(Data);
43+ Data = Request.PerformWebRequest(Data, "POST");
44
45 return Data.Statuses[0];
46 }
47
48=== modified file 'Microblogging/src/Twitterizer/Twitterizer.Framework/MethodClasses/TwitterUserMethods.cs'
49--- Microblogging/src/Twitterizer/Twitterizer.Framework/MethodClasses/TwitterUserMethods.cs 2008-12-11 04:16:01 +0000
50+++ Microblogging/src/Twitterizer/Twitterizer.Framework/MethodClasses/TwitterUserMethods.cs 2009-04-17 02:15:08 +0000
51@@ -95,9 +95,7 @@
52
53 string actionUri = (Parameters == null ? Twitter.Urls.FriendsUrl : Parameters.BuildActionUri(Twitter.Urls.FriendsUrl));
54 Data.ActionUri = new Uri(actionUri);
55-
56 Data = Request.PerformWebRequest(Data);
57-
58 return Data.Users;
59 }
60 }
61
62=== modified file 'Microblogging/src/Twitterizer/Twitterizer.Framework/TwitterRequest.cs'
63--- Microblogging/src/Twitterizer/Twitterizer.Framework/TwitterRequest.cs 2008-12-11 04:16:01 +0000
64+++ Microblogging/src/Twitterizer/Twitterizer.Framework/TwitterRequest.cs 2009-04-17 02:15:08 +0000
65@@ -40,7 +40,7 @@
66 {
67 public TwitterRequestData PerformWebRequest(TwitterRequestData Data)
68 {
69- PerformWebRequest(Data, "POST");
70+ PerformWebRequest(Data, "GET");
71
72 return (Data);
73
74@@ -48,8 +48,7 @@
75
76 public TwitterRequestData PerformWebRequest(TwitterRequestData Data, string HTTPMethod)
77 {
78- HttpWebRequest Request = (HttpWebRequest)WebRequest.Create(Data.ActionUri);
79-
80+ HttpWebRequest Request = (HttpWebRequest)WebRequest.Create(Data.ActionUri);
81
82 Request.Method = HTTPMethod;
83
84@@ -99,7 +98,7 @@
85 {
86 XmlDocument ResultXmlDocument = new XmlDocument();
87 ResultXmlDocument.LoadXml(Data.Response);
88-
89+
90 if (ResultXmlDocument.DocumentElement != null)
91 switch (ResultXmlDocument.DocumentElement.Name.ToLower())
92 {

Subscribers

People subscribed via source and target branches