Ubuntu
gnome-power-manager package

Merge lp://qastaging/~alexlauni/ubuntu/lucid/gnome-power-manager/gpm-fix-530751 into lp://qastaging/ubuntu/lucid/gnome-power-manager

Lucid (10.04)
gpm-fix-530751
Merge into lucid

Proposed by Alex Launi on 2010-03-08

Status:

Rejected

Rejected by:

James Westby on 2012-03-08

Proposed branch:

lp://qastaging/~alexlauni/ubuntu/lucid/gnome-power-manager/gpm-fix-530751

Merge into:

lp://qastaging/ubuntu/lucid/gnome-power-manager

Diff against target:

50 lines (+30/-0)

3 files modified

debian/changelog (+8/-0)
debian/patches/19_ac_power_notify_osd_spec.patch (+21/-0)
debian/patches/series (+1/-0)

To merge this branch:

bzr merge lp://qastaging/~alexlauni/ubuntu/lucid/gnome-power-manager/gpm-fix-530751

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Terry	ubuntu-sponsor		Needs Fixing on 2010-12-22
James Westby (community)		2010-03-08	Abstain on 2010-03-12
Chris Coulson		2010-03-12	Pending
Review via email: mp+20920@code.qastaging.launchpad.net

Description of the change

Updates the g-p-m notification for unplugging an AC power adapter to conform to the text specified in https://wiki.ubuntu.com/NotifyOSD#gnome-power-manager

Revision history for this message

James Westby (james-w) on 2010-03-12:

review: Abstain

Revision history for this message

Andrea Corbellini (andrea.corbellini) wrote on 2010-08-09:

Hello. Here:

- message = g_strdup_printf (_("%s discharging (%.1f%%)"),
+ message = g_strdup_printf (_("%.1f%% of %s remaining"),

You have inverted the order of the two parameters (%s and %.1f), but forgot to invert the arguments of the function call (type_desc and percentage).

Revision history for this message

Michael Terry (mterry) wrote on 2010-12-22:

In addition, the recommended wording from https://wiki.ubuntu.com/NotifyOSD is "Running on battery" not "AC power disconnected".

The same change should be made to the UPS notifications right below that block of code too.

review: Needs Fixing (ubuntu-sponsor)

Revision history for this message

James Westby (james-w) wrote on 2012-03-08:

Hi,

I'm assuming that we don't want to fix this is the released lucid now.
If it's still relevant then please re-propose, or propose for precise as
appropriate.

Thanks,

James

Unmerged revisions

165. By Alex Launi on 2010-03-08: * debian/patches/19_ac_power_notify_osd_spec.patch
- Update AC unplugged notification to conform to notify OSD
specification. (LP: #530751).
164. By Alex Launi on 2010-03-08: Update AC unplugged notification to conform to Notify OSD g-p-m specification