Merge lp://qastaging/~alexlist/charms/trusty/swift-storage/relax-directory-permissions-for-monitoring into lp://qastaging/~openstack-charmers-archive/charms/trusty/swift-storage/next

Proposed by Alexander List
Status: Merged
Merged at revision: 37
Proposed branch: lp://qastaging/~alexlist/charms/trusty/swift-storage/relax-directory-permissions-for-monitoring
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/swift-storage/next
Diff against target: 27 lines (+4/-2)
1 file modified
hooks/swift_storage_utils.py (+4/-2)
To merge this branch: bzr merge lp://qastaging/~alexlist/charms/trusty/swift-storage/relax-directory-permissions-for-monitoring
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
James Page Pending
Review via email: mp+224574@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-06-23.

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote : Posted in a previous version of this proposal

I'd prefer to limit this to /srv/node - the other two directories should probably not be world readable as they potentially contain files directly.

35. By Alexander List

[alexlist] update chmod to allow df and monitoring to access /srv/node

Revision history for this message
Stuart Bishop (stub) wrote :

Jame's comments have been addressed and the rest of the changes look fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches