Merge ~alextu/pc-enablement/+git/oem-scripts:rsync_iso into ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master

a test on random usb disk:
https://pastebin.canonical.com/p/5Y4j8CWjzz/

a test result over VPN.
$ rsync_iso.sh --jenkins-url jenkins.canonical.pw --jenkins-job dell-bto-focal-fossa-edge-alloem-init -s
https://pastebin.canonical.com/p/8h8Zbzy3Pc/

It will popup a dialog reminding you in the end.
https://i.imgur.com/v20GtNB.png

Test pass on local machine.

$ ./rsync_iso.sh ~/Downloads/dell-bto-focal-fossa-pypar-adl-X163-20211027-6.iso -f /media/andch/Dell\ Recovery\ Media/ -s

https://pastebin.canonical.com/p/88vfNxRzHM/

Can we remove set -x?

By the way, tmp.xxxx folder won't be deleted after installation usb is finished.

$ ls
tmp.Oe7dubjaNd

sure thing, let me remove the set -x and fix the un-deleted `tmp.xxxx`

Test done.

sent 4,145,771,921 bytes received 42,432 bytes 236,903,677.31 bytes/sec
total size is 4,144,596,677 speedup is 1.00
================================================================
    dell-bto-focal-fossa-tentacool-X169-20211014-12.iso
================================================================
~/oem-scripts/tmp.AAZF4XBUX7 ~/oem-scripts
~/oem-scripts
/usr/bin/zenity
umount: /home/andch/oem-scripts/tmp.ICAjrBvoSh: no mount point specified.
umount: /home/andch/oem-scripts/tmp.AAZF4XBUX7: no mount point specified.

LGTM

[autopkgtest]
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
oem-meta-packages PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
mir-bug FAIL non-zero exit status 1
git-url-insteadof-setting FAIL non-zero exit status 128
recovery-from-iso.sh PASS
mir-bug-verification FAIL stderr: E: Unable to locate package oem-somerville-maester-meta

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts-0.99-56821cb-in-linux-container-focal

testing for commit 215f181:

# Environment:
2 USB disks be plugged
sda 8:0 1 58.4G 0 disk
└─sda1 8:1 1 58.4G 0 part /media/alextu/C695-6B4E
sdb 8:16 1 14.5G 0 disk
└─sdb1 8:17 1 14.5G 0 part /media/alextu/CEC2-88FB

# verified command
$ ./rsync_iso.sh --jenkins-url jenkins.canonical.pw --jenkins-job dell-bto-focal-fossa-edge-alloem-init --jenkins-job-number 18 --all-usb -s 2>&1 | tee log

https://pastebin.canonical.com/p/kRc2P2x3Rg/

# result, 2 USB disks be made successfully.

Verified manually that by using the following command:
./rsync_iso.sh --jenkins-url jenkins.canonical.pw --jenkins-job dell-bto-focal-fossa-edge-alloem-init

The external disk I plugged in has been formatted into FAT32 and files from dell-bto-focal-fossa-edge-alloem-init-X186-20220111-27.iso has been copied over.

Other than having too much log messages (suggested by andch to remove set -x), it LGTM.

+1, to remove the set -x.

[autopkgtest]
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
oem-meta-packages PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
mir-bug FAIL non-zero exit status 1
git-url-insteadof-setting FAIL non-zero exit status 128
recovery-from-iso.sh PASS
mir-bug-verification PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-0.99-2b0b120-in-linux-container-focal