Merge lp://qastaging/~alisonken1/openlp/bug-1593883-projector-authentication into lp://qastaging/openlp

Proposed by Ken Roberts
Status: Merged
Merged at revision: 2678
Proposed branch: lp://qastaging/~alisonken1/openlp/bug-1593883-projector-authentication
Merge into: lp://qastaging/openlp
Diff against target: 172 lines (+74/-12)
5 files modified
openlp/core/common/__init__.py (+4/-3)
openlp/core/lib/projector/pjlink1.py (+16/-5)
openlp/plugins/presentations/lib/powerpointcontroller.py (+1/-1)
tests/functional/openlp_core_common/test_projector_utilities.py (+2/-2)
tests/functional/openlp_core_lib/test_projector_pjlink1.py (+51/-1)
To merge this branch: bzr merge lp://qastaging/~alisonken1/openlp/bug-1593883-projector-authentication
Reviewer Review Type Date Requested Status
Tomas Groth Approve
Tim Bentley Approve
Review via email: mp+297819@code.qastaging.launchpad.net

Commit message

Bugfix 1593882 and 1593883 - projector authorization

Description of the change

Bugfix 1593882 and 1593883 - projector authorization

- Fix exception when authenticated connection requested and pin is None
- Fix pjlink authentication (use python hash instead of qt hash)
- Fix md5_hash functions
- Fix qmd5hash functions
- Added tests for bugfixes
Tested with test server and Eiki XL200 projector

--------------------------------
lp:~alisonken1/openlp/bug-1593883-projector-authentication (revision 2684)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1629/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1540/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1478/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/1247/
[SUCCESS] https://ci.openlp.io/job/Branch-04b-Windows_Interface_Tests/837/
[SUCCESS] https://ci.openlp.io/job/Branch-05a-Code_Analysis/905/
[SUCCESS] https://ci.openlp.io/job/Branch-05b-Test_Coverage/773/

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) :
review: Approve
2685. By Ken Roberts

Format fix

Revision history for this message
Tomas Groth (tomasgroth) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.