Merge lp://qastaging/~alisonken1/openlp/bug-1734275 into lp://qastaging/openlp
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 2791 | ||||
| Proposed branch: | lp://qastaging/~alisonken1/openlp/bug-1734275 | ||||
| Merge into: | lp://qastaging/openlp | ||||
| Diff against target: |
312 lines (+156/-98) 5 files modified
openlp/core/projectors/manager.py (+7/-5) openlp/core/projectors/pjlink.py (+14/-11) tests/functional/openlp_core/projectors/test_projector_bugfixes_01.py (+134/-0) tests/functional/openlp_core/projectors/test_projector_pjlink_base.py (+1/-53) tests/functional/openlp_core/projectors/test_projector_pjlink_commands.py (+0/-29) |
||||
| To merge this branch: | bzr merge lp://qastaging/~alisonken1/openlp/bug-1734275 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Bentley | Pending | ||
| Phill | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2017-11-24.
Commit message
Bugfix 1734275 - PJLink non-standard response to LAMP command
Description of the change
- Fix non-standard LAMP response (bug 1734275)
- Moved bugfix tests to separate file
- Added test for non-standard LAMP response
- Refactor mocks
- Cleanups
-------
lp:~alisonken1/openlp/bug-1734275 (revision 2792)
https:/
https:/
https:/
https:/
https:/
https:/
https:/
| Tim Bentley (trb143) | # |
| Phill (phill-ridout) wrote | # |
| Phill (phill-ridout) | # |
| Phill (phill-ridout) | # |
A few inline comments, nothing major Sorry if it seems like I be tripping on my new status! :-p