Merge lp://qastaging/~allenap/bzr-update-copyright/force-ranges-on-commit into lp://qastaging/bzr-update-copyright

Proposed by Gavin Panella
Status: Merged
Approved by: Richard Wilbur
Approved revision: 18
Merged at revision: 17
Proposed branch: lp://qastaging/~allenap/bzr-update-copyright/force-ranges-on-commit
Merge into: lp://qastaging/bzr-update-copyright
Diff against target: 99 lines (+54/-5)
2 files modified
__init__.py (+23/-5)
test_update_copyright.py (+31/-0)
To merge this branch: bzr merge lp://qastaging/~allenap/bzr-update-copyright/force-ranges-on-commit
Reviewer Review Type Date Requested Status
Richard Wilbur Approve
Review via email: mp+295604@code.qastaging.launchpad.net

Commit message

Allow optional --force-range behaviour in commit hooks.

To post a comment you must log in.
Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

I like the changes. Please update the documentation in __init__.py docstring to describe the new capability. If you can't get to that right now, let me know and I can do it.

review: Needs Fixing
18. By Gavin Panella

Update documentation for commit hook.

Revision history for this message
Gavin Panella (allenap) wrote :

> Please update the documentation in __init__.py docstring to describe
> the new capability.

Done.

Thanks!

Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

Looks great, Gavin! Thanks for the new, documented functionality.
+2

review: Approve
Revision history for this message
Gavin Panella (allenap) wrote :

Richard, I don't have write access to lp:bzr-update-copyright. Would you merge it for me? Thanks.

Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

Gavin, I'll be happy to merge it for you tomorrow. I've been very
busy lately or I would have merged it the day I approved it.

Revision history for this message
Gavin Panella (allenap) wrote :

Thanks, that's grand.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches