MAAS

Merge lp://qastaging/~allenap/maas/subnet-attribute-error--bug-1671048 into lp://qastaging/~maas-committers/maas/trunk

  1. subnet-attribute-error--bug-1671048
  2. Merge into trunk
Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: 5829
Proposed branch: lp://qastaging/~allenap/maas/subnet-attribute-error--bug-1671048
Merge into: lp://qastaging/~maas-committers/maas/trunk
Diff against target: 140 lines (+43/-20)
2 files modified
src/maasserver/models/node.py (+4/-4)
src/maasserver/models/tests/test_node.py (+39/-16)
To merge this branch: bzr merge lp://qastaging/~allenap/maas/subnet-attribute-error--bug-1671048
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+320512@code.qastaging.launchpad.net

Commit message

Node.get_default_gateways now always returns a DefaultGateways instance which contains two GatewayDefinition instances.

Previously plain tuples were sometimes returned instead of GatewayDefinition named tuples.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good. Thanks for the quick fix.

review: Approve
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Don't forget the backport.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.