lp://qastaging/~alphapapa/pithos/888778
- Get this branch:
- bzr branch lp://qastaging/~alphapapa/pithos/888778
Branch merges
- Kevin Mehall: Pending requested
-
Diff: 442 lines (+210/-67)8 files modified.bzrignore (+1/-0)
bin/pithos (+13/-3)
data/ui/PreferencesPithosDialog.ui (+36/-21)
pithos/PreferencesPithosDialog.py (+6/-3)
pithos/dbus_service.py (+5/-1)
pithos/plugins/mediakeys.py (+15/-9)
pithos/plugins/notification_icon.py (+29/-30)
pithos/plugins/status_icon.py (+105/-0)
Related bugs
Bug #627218: Wrong icons in KDE | Undecided | Confirmed |
|
Bug #858565: Feature Request: Right-click tray icon as well as left-click | Undecided | New |
|
Bug #888778: DBus: change Present to a show/hide toggle | Undecided | In Progress |
|
Related blueprints
Branch information
Recent revisions
- 188. By Adam Porter
-
The libindicator icon doesn't work that well, at least on KDE. 1) It doesn't support the left-click event on KDE, 2) it doesn't show the right icons on KDE. And these bugs depend on libappindicator being updated--we're at their mercy. So I made a "status_icon" plugin that's just a copy of the notification_icon plugin without the libindicator code, so it only uses a Gtk status icon. And that shows the right icons on KDE and supports the left-click event, so a simple left click shows and hides the window. The preferences allow either or both to be enabled, so users can try both. I suppose a group enabled by a checkbox containing radio buttons might be more correct, but this is simple and works.
- 185. By Adam Porter
-
Updated notification_icon plugin to use new main toggle_window() function.
Added separators in indicator icon menus; looks much better.
Fixed incorrect labels in indicator icon menus (on KDE, at least, they were using Gtk stock labels, e.g. "Jump to" instead of "Tired").
Turned off icons in indicator menu due to #627218. At least it's consistent this way. Also, the trend is moving away from icons in menus toward a cleaner look--Unity doesn't even allow them. - 184. By Adam Porter
-
Changed bring_to_top() to toggle_window() and added ToggleWindow DBUS method. Left Present method for backwards-
compatibility with existing users. :) - 183. By Adam Porter
-
Fixed so the bring_to_top() toggle will iconify if the notification icon is off, but hide if it's on.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://qastaging/~kevin-mehall/pithos/trunk