Online Accounts: Account plugins

Merge lp://qastaging/~amigadave/account-plugins/add-some-tests into lp://qastaging/account-plugins

  1. add-some-tests
  2. Merge into trunk
Proposed by David King
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 88
Merged at revision: 85
Proposed branch: lp://qastaging/~amigadave/account-plugins/add-some-tests
Merge into: lp://qastaging/account-plugins
Diff against target: 93 lines (+45/-3)
3 files modified
.bzrignore (+2/-0)
Makefile.am (+26/-2)
configure.ac (+17/-1)
To merge this branch: bzr merge lp://qastaging/~amigadave/account-plugins/add-some-tests
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Ken VanDine Pending
Review via email: mp+138393@code.qastaging.launchpad.net

Commit message

Add a couple of simple tests

* Add tests for well-formed XML files
* Enable automake silent rules

Description of the change

Add a couple of simple tests

* Add tests for well-formed XML files
* Enable automake silent rules

To post a comment you must log in.
Revision history for this message
David King (amigadave) wrote :

This checks the .provider and .service files with xmllint. It does not check against the DTDs provided by libaccounts-glib, as those will not be available until a future 1.4 release. Some tests for the binary plugins could be provided, but I am not sure how to approach that problem at the moment.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:86
http://s-jenkins:8080/job/account-plugins-ci/10/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/account-plugins-ci/./build=pbuilder,distribution=raring,flavor=amd64/10/console
    FAILURE: http://s-jenkins:8080/job/account-plugins-ci/./build=pbuilder,distribution=raring,flavor=i386/10/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/account-plugins-ci/10//rebuild/?

review: Needs Fixing (continuous-integration)
lp://qastaging/~amigadave/account-plugins/add-some-tests updated
87. By David King

Enable the XML tests only if xmllint is present

88. By David King

Force tests to be enabled during distcheck

Add an --enable-tests configure argument, and add it to
DISTCHECK_CONFIGURE_FLAGS.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:88
http://s-jenkins:8080/job/account-plugins-ci/11/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/account-plugins-ci/./build=pbuilder,distribution=raring,flavor=amd64/11/console
    SUCCESS: http://s-jenkins:8080/job/account-plugins-ci/./build=pbuilder,distribution=raring,flavor=i386/11/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/account-plugins-ci/11//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

I don't think there is much sense in making tests for the binary plugins, are they mostly consist of data only -- which BTW will soon be migrated to the provider files, once the new libaccounts-glib is released.

Anyway, this MR makes lots of sense, thanks! :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches