Online Accounts: GNOME Control Center

Merge lp://qastaging/~amigadave/gnome-control-center-signon/avoid-deletion-warning into lp://qastaging/gnome-control-center-signon

  1. avoid-deletion-warning
  2. Merge into trunk
Proposed by David King
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 100
Merged at revision: 96
Proposed branch: lp://qastaging/~amigadave/gnome-control-center-signon/avoid-deletion-warning
Merge into: lp://qastaging/gnome-control-center-signon
Diff against target: 287 lines (+17/-216)
4 files modified
Makefile.am (+4/-6)
src/accounts.deps (+0/-1)
src/accounts.vapi (+0/-205)
src/cc-credentials-account-details-page.vala (+13/-4)
To merge this branch: bzr merge lp://qastaging/~amigadave/gnome-control-center-signon/avoid-deletion-warning
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
jenkins (community) continuous-integration Needs Fixing
Review via email: mp+122667@code.qastaging.launchpad.net

Description of the change

Avoid a warning when deleting an account

* Update libaccount-glib VAPI file for AgAccountsError
* Check error when attempting to enable an account
* Do not use EXTRA_DIST in Makefile.am

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:99
http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/36/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/./label=quantal/36/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Works fine, thanks.
But please use the .vapi file shipped with libaccounts-glib (you already applied these changes there :-) ).

review: Needs Fixing
lp://qastaging/~amigadave/gnome-control-center-signon/avoid-deletion-warning updated
100. By David King

Remove libaccounts-glib VAPI file

Instead, use the VAPI file provided by libaccounts-glib.

Revision history for this message
David King (amigadave) wrote :

Right you are, I have removed the VAPI file now.

Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:100
http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/37/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/./label=quantal/37/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Perfect, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: