Online Accounts: GNOME Control Center

Merge lp://qastaging/~amigadave/gnome-control-center-signon/fiddle-make-rules into lp://qastaging/gnome-control-center-signon

  1. fiddle-make-rules
  2. Merge into trunk
Proposed by David King
Status: Merged
Approved by: David King
Approved revision: 147
Merged at revision: 143
Proposed branch: lp://qastaging/~amigadave/gnome-control-center-signon/fiddle-make-rules
Merge into: lp://qastaging/gnome-control-center-signon
Diff against target: 134 lines (+29/-28)
3 files modified
Makefile.am (+13/-13)
configure.ac (+10/-10)
tools/update-accounts.c (+6/-5)
To merge this branch: bzr merge lp://qastaging/~amigadave/gnome-control-center-signon/fiddle-make-rules
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alberto Mardegan (community) Approve
Review via email: mp+154985@code.qastaging.launchpad.net

Commit message

Avoid some warnings

Description of the change

Some small fixes and changes

* Pass -delete to find rather than using rm -rf
* Rename lcov configure argument to coverage
* Only call g_type_init() with GLib < 2.35.1
* Avoid deprecated ag_account_get_value()
* Avoid use of add_prefix in Makefile.am

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:147
http://s-jenkins:8080/job/gnome-control-center-signon-ci/43/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/43
    SUCCESS: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/43

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/43/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/22/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/22/console
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/./build=pbuilder,distribution=raring,flavor=i386/22/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: