Online Accounts: GNOME Control Center

Merge lp://qastaging/~amigadave/gnome-control-center-signon/fix-grant-access into lp://qastaging/gnome-control-center-signon

  1. fix-grant-access
  2. Merge into trunk
Proposed by David King
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 102
Merged at revision: 102
Proposed branch: lp://qastaging/~amigadave/gnome-control-center-signon/fix-grant-access
Merge into: lp://qastaging/gnome-control-center-signon
Diff against target: 135 lines (+74/-19)
1 file modified
src/cc-credentials-account-details-page.vala (+74/-19)
To merge this branch: bzr merge lp://qastaging/~amigadave/gnome-control-center-signon/fix-grant-access
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+124218@code.qastaging.launchpad.net

Description of the change

Update the ‘Grant access’ button state correctly

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:102
http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/45/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/./label=quantal/45/console

review: Approve (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Hi David, I'm testing the fix right now. Meanwhile please fix the indentation in lines 18+ in src/cc-credentials-account-details-page.vala :-)

lp://qastaging/~amigadave/gnome-control-center-signon/fix-grant-access updated
102. By David King

Update the ‘Grant access’ button state correctly

The visibility of the ‘Grant access’ button inside the action notebook
of AccountDetailsPage was not updated after a successful
reauthorization. Add a ‘row-changed’ handler to AccountDetailsPage and
update the action page state depending on if the ‘needs-attention’ flag
is set for the current account.

Revision history for this message
David King (amigadave) wrote :

Yikes! Updated.

Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks! Works perfectly!!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: