Merge lp://qastaging/~andersk/bzr-fastimport/git-darcs into lp://qastaging/bzr-fastimport

Proposed by Anders Kaseorg
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: 282
Merged at revision: 283
Proposed branch: lp://qastaging/~andersk/bzr-fastimport/git-darcs
Merge into: lp://qastaging/bzr-fastimport
Diff against target: 284 lines (+46/-55)
2 files modified
exporters/darcs/darcs-fast-export (+10/-19)
exporters/darcs/git-darcs (+36/-36)
To merge this branch: bzr merge lp://qastaging/~andersk/bzr-fastimport/git-darcs
Reviewer Review Type Date Requested Status
Miklos Vajna code Pending
Ian Clatworthy Pending
Review via email: mp+22279@code.qastaging.launchpad.net

Description of the change

Some fixes for git-darcs, including Daniel Herring’s patch from bug 538933.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

The git-darcs changes are fairly simple and seem ok to me.

Miklos, you are a lot more familiar with the darcs exporter code. Any chance you can do a review of that code?

Revision history for this message
Miklos Vajna (vmiklos) wrote :

On Sat, Oct 09, 2010 at 01:31:38PM -0000, Jelmer Vernooij <email address hidden> wrote:
> Miklos, you are a lot more familiar with the darcs exporter code. Any
> chance you can do a review of that code?

Sure, I'll try to review it in the near future. :)

Revision history for this message
Miklos Vajna (vmiklos) wrote :

On Wed, Oct 13, 2010 at 01:49:57AM +0200, Miklos Vajna <email address hidden> wrote:
> Sure, I'll try to review it in the near future. :)

Sorry for being slow, looks good.

Jelmer, please merge it.

Thanks.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks for the review.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches