Merge lp://qastaging/~andersk/ubuntu/raring/usb-creator/upstart-cleanup into lp://qastaging/ubuntu/raring/usb-creator
Proposed by
Anders Kaseorg
| Status: | Merged |
|---|---|
| Merge reported by: | Dimitri John Ledkov |
| Merged at revision: | not available |
| Proposed branch: | lp://qastaging/~andersk/ubuntu/raring/usb-creator/upstart-cleanup |
| Merge into: | lp://qastaging/ubuntu/raring/usb-creator |
| Diff against target: |
18 lines (+3/-5) 1 file modified
debian/usb-creator-gtk.upstart (+3/-5) |
| To merge this branch: | bzr merge lp://qastaging/~andersk/ubuntu/raring/usb-creator/upstart-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Dimitri John Ledkov (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Instead of running a shell script every time a USB device is plugged in, just check ID_VENDOR_ID and ID_MODEL in the upstart ‘start on’ stanza. The shell script was ugly and seemed to be leading to spurious usb-creator-gtk popups.
To post a comment you must log in.
Revision history for this message
| Dimitri John Ledkov (xnox) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Yeap, I was talking to slangasek and he pointed out the same thing.