Merge lp://qastaging/~andreagrandi/unity-2d/bug750303 into lp://qastaging/unity-2d/3.0

Thanks a lot for that Andrea!

The schema should only contain keys that belong to Unity 2D, that is keys that are under "/desktop/unity-2d/". Anything related to metacity or GNOME, etc. should not be in there.

Each schema should contain some documentation of what the key is/does as in the following:

  <locale name="C">
    <short>Default font</short>
      <long>Name of the default font used by gtk+.</long>
  </locale>

The <applyto> tag should contain the exact GConf path of the GConf key.
The <key> tag should contain that path with '/schemas/' prepended to it.
For example:

<key>/desktop/unity-2d/launcher/favorites</key>
<applyto>/schemas/desktop/unity-2d/launcher/favorites</applyto>

Hi,

> Thanks a lot for that Andrea!
>
> The schema should only contain keys that belong to Unity 2D, that is keys that
> are under "/desktop/unity-2d/". Anything related to metacity or GNOME, etc.
> should not be in there.

ok, going to remove stuff not related to unity-2d

> Each schema should contain some documentation of what the key is/does as in
> the following:
>
> <locale name="C">
> <short>Default font</short>
> <long>Name of the default font used by gtk+.</long>
> </locale>

where can I find the description to use?

> The <applyto> tag should contain the exact GConf path of the GConf key.
> The <key> tag should contain that path with '/schemas/' prepended to it.
> For example:
>
> <key>/desktop/unity-2d/launcher/favorites</key>
> <applyto>/schemas/desktop/unity-2d/launcher/favorites</applyto>

you say one thing and you do another in the example: which one must have the "/schemas/" ?! key or applyto?

> Hi,
>
> > Thanks a lot for that Andrea!
> >
> > The schema should only contain keys that belong to Unity 2D, that is keys
> that
> > are under "/desktop/unity-2d/". Anything related to metacity or GNOME, etc.
> > should not be in there.
>
> ok, going to remove stuff not related to unity-2d
>
> > Each schema should contain some documentation of what the key is/does as in
> > the following:
> >
> > <locale name="C">
> > <short>Default font</short>
> > <long>Name of the default font used by gtk+.</long>
> > </locale>
>
> where can I find the description to use?

Well, it's never been written down so we need to make it up. I tried to write up something:

/desktop/unity-2d/launcher/favorites

Favorite applications

List of desktop files of applications that have been marked as favorites by the user in the launcher

/desktop/unity-2d/launcher/hide_mode

Hiding mode of the launcher

Possible values:
0: never hide; the launcher is always visible. Always set /desktop/unity-2d/launcher/use_strut to true when using that mode
1: auto hide; the launcher will disappear after a short time if the user is not interacting with it
2: intellihide; the launcher will disappear if a window is placed on top of it and if the user is not interacting with it

/desktop/unity-2d/launcher/use_strut

Reserve launcher area

Use EWMH standard to reserve an area of the desktop (struts) so that no window can use the launcher's area

/desktop/unity-2d/launcher/super_key_enable

Super key activation

Whether or not the super (also called windows key) key is used

>
> > The <applyto> tag should contain the exact GConf path of the GConf key.
> > The <key> tag should contain that path with '/schemas/' prepended to it.
> > For example:
> >
> > <key>/desktop/unity-2d/launcher/favorites</key>
> > <applyto>/schemas/desktop/unity-2d/launcher/favorites</applyto>
>
> you say one thing and you do another in the example: which one must have the
> "/schemas/" ?! key or applyto?

That's because I am very silly :)
I meant:

<key>/schemas/desktop/unity-2d/launcher/favorites</key>
<applyto>/desktop/unity-2d/launcher/favorites</applyto>

I should have fixed all the things you requested me. Feel free to review and merge if all is ok.

Looks great Andrea, I'll give it a test (building the Ubuntu package, installing it and checking it works as expected) tomorrow.

> Looks great Andrea, I'll give it a test (building the Ubuntu package,
> installing it and checking it works as expected) tomorrow.

Hi Florian, was the schema ok? Please let me know! :)

Thanks Andrea, sorry for the delay.

A couple of things are missing:
* the schema file should be named unity-2d.schemas
* the schema file should be installed in /usr/share/gconf/schemas/ instead of /usr/share/gconf/ as it is currently
* while trying to register the schema, a few warnings showed up:

kaleo@tequila:~$ sudo gconf-schemas --register /usr/share/gconf/schemas/unity-2d.schemas
WARNING: no <list_type> specified for schema of type list
WARNING: invalid or missing list_type for schema (/schemas/desktop/unity-2d/launcher/favorites)
WARNING: failed to install schema `/schemas/desktop/unity-2d/launcher/favorites', locale `C': Schema specifies type list but doesn't specify the type of the list elements

I think for the list type it should look something like:

<schema>
<key>/schemas/desktop/unity-2d/launcher/favorites</key>
<applyto>/desktop/unity-2d/launcher/favorites</applyto>
<owner>unity-2d</owner>
<type>list</type>
<list_type>string</list_type>
[...]

Hi,

> * the schema file should be named unity-2d.schemas

done

> * the schema file should be installed in /usr/share/gconf/schemas/ instead of
> /usr/share/gconf/ as it is currently

moved

> * while trying to register the schema, a few warnings showed up:
>
> kaleo@tequila:~$ sudo gconf-schemas --register /usr/share/gconf/schemas/unity-
> 2d.schemas
> WARNING: no <list_type> specified for schema of type list
> WARNING: invalid or missing list_type for schema (/schemas/desktop/unity-
> 2d/launcher/favorites)
> WARNING: failed to install schema `/schemas/desktop/unity-
> 2d/launcher/favorites', locale `C': Schema specifies type list but doesn't
> specify the type of the list elements

try if with the latest fix it's working as expected.

Fantastic Andrea! We can merge now :)