Mir

Merge lp://qastaging/~andreas-pokorny/mir/fix-missing-system-path into lp://qastaging/mir

  1. fix-missing-system-path
  2. Merge into development-branch
Proposed by Andreas Pokorny
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 1293
Proposed branch: lp://qastaging/~andreas-pokorny/mir/fix-missing-system-path
Merge into: lp://qastaging/mir
Diff against target: 14 lines (+2/-2)
1 file modified
cmake/LinuxCrossCompile.cmake (+2/-2)
To merge this branch: bzr merge lp://qastaging/~andreas-pokorny/mir/fix-missing-system-path
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Daniel van Vugt Approve
Kevin DuBois (community) Approve
kevin gunn (community) Approve
Review via email: mp+199529@code.qastaging.launchpad.net

Commit message

Fixes the build problem with the current chroot setup.
This fixes Mir build failures (LP: #1262305)

Description of the change

Fixes the build problem with the current chroot setup.

To post a comment you must log in.
Revision history for this message
kevin gunn (kgunn72) wrote :

lgtm

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

I guess this okay. The real fix is to depend-upon android-headers (which deprecated android-platform-headers) and use cmake's pkgconfig utilities to figure this out.

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

I'll revise, this is probably okay as a band aid. we should use the real fix as quickly as possible

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yep, it does fix the bug.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches