Mir

Merge lp://qastaging/~andreas-pokorny/mir/map-onto-uppercase-letters-when-caps-lock-is-on into lp://qastaging/mir

  1. map-onto-uppercase-letters-when-caps-lock-is-on
  2. Merge into development-branch
Proposed by Andreas Pokorny
Status: Rejected
Rejected by: Andreas Pokorny
Proposed branch: lp://qastaging/~andreas-pokorny/mir/map-onto-uppercase-letters-when-caps-lock-is-on
Merge into: lp://qastaging/mir
Prerequisite: lp://qastaging/~andreas-pokorny/mir/serverside-keymap-based-modifier-tracking
Diff against target: 56 lines (+17/-14)
2 files modified
src/client/input/xkb_mapper.cpp (+1/-14)
tests/unit-tests/client/input/test_xkb_mapper.cpp (+16/-0)
To merge this branch: bzr merge lp://qastaging/~andreas-pokorny/mir/map-onto-uppercase-letters-when-caps-lock-is-on
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
Mir CI Bot continuous-integration Approve
Cemil Azizoglu (community) Approve
Review via email: mp+296861@code.qastaging.launchpad.net

Commit message

Fix Caps Lock key state

Use xkb_state_key_get_one_sym instead of _syms. The former calculates an upper case version of the key pressed, the latter does nothing of that.

Description of the change

We used an xkbcommon method that for some reason bypassed caps lock processing for some of the keysyms.

To post a comment you must log in.
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

straightforward enough

review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3516
https://mir-jenkins.ubuntu.com/job/mir-ci/1122/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/1242
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1292
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1283
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1283
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/1252
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/1252/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/1252
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/1252/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1252
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1252/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1252
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1252/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/1252
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/1252/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1122/rebuild

review: Approve (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) :
review: Approve

Unmerged revisions

3516. By Andreas Pokorny

and again

3515. By Andreas Pokorny

cleanup test case

3514. By Andreas Pokorny

Fix Caps Lock key state

Use xkb_state_key_get_one_sym instead of _syms. The former calculates an uper cased version of the key pressed, the latter does nothing of that.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches