Merge lp://qastaging/~andrebachmann-dd/bzr-explorer/fix-bzrlog into lp://qastaging/bzr-explorer
Proposed by
André Bachmann
| Status: | Merged |
|---|---|
| Approved by: | Martin Packman |
| Approved revision: | 567 |
| Merged at revision: | 566 |
| Proposed branch: | lp://qastaging/~andrebachmann-dd/bzr-explorer/fix-bzrlog |
| Merge into: | lp://qastaging/bzr-explorer |
| Diff against target: |
39 lines (+5/-6) 2 files modified
NEWS (+3/-0) lib/app_suite.py (+2/-6) |
| To merge this branch: | bzr merge lp://qastaging/~andrebachmann-dd/bzr-explorer/fix-bzrlog |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Packman (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Simple fix for the problem with Bazaar on Windows that you got a Windows error 123 when trying to view the bzr system log via bzr-explorer.
To post a comment you must log in.
Revision history for this message
| André Bachmann (andrebachmann-dd) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
You need to at least update the comments as you're updating the code. :)
Only real question is what version the split function was fixed, against how far back bzr-explorer tries to remain compatible. Checking now, seems it's been in bzrlib since 2.2, and bzr-explorer was updated in r513 to use the unbroken version, but these comments were missed so the quote hack didn't get reverted.
A cleanup of this module not to use command line strings would be nice, but isn't needed here. Just fix or delete the outdated comments and this will do.