Merge lp://qastaging/~andreserl/maas/lp1561954 into lp://qastaging/~maas-maintainers/maas/packaging

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 490
Merged at revision: 478
Proposed branch: lp://qastaging/~andreserl/maas/lp1561954
Merge into: lp://qastaging/~maas-maintainers/maas/packaging
Diff against target: 412 lines (+298/-22)
10 files modified
debian/changelog (+6/-2)
debian/control (+23/-3)
debian/maas-common.templates (+34/-1)
debian/maas-rack-controller.postinst (+1/-0)
debian/maas-rack-controller.templates (+0/-16)
debian/maas-rack-udeb.postinst (+77/-0)
debian/maas-rack-udeb.templates (+36/-0)
debian/maas-region-controller.postinst (+10/-0)
debian/maas-region-udeb.postinst (+82/-0)
debian/maas-region-udeb.templates (+29/-0)
To merge this branch: bzr merge lp://qastaging/~andreserl/maas/lp1561954
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
LaMont Jones (community) Approve
Mathieu Trudel-Lapierre (community) Needs Fixing
Review via email: mp+291259@code.qastaging.launchpad.net

Commit message

Add maas-region-udeb and maas-rack-udeb to be used as part of the Ubuntu Server Installer (LP: #1561954)

To post a comment you must log in.
483. By Andres Rodriguez

* New upstream release, 2.0.0 beta 2 bzr 4883 (Standing FFe LP: #1553261)
* Add maas-region-udeb and maas-rack-udeb to be used as part of the
  Ubuntu Server Installer (LP: #1561954)
  - ensure maas-rack-controller and maas-region-controller can be fully
    preseeded.

484. By Andres Rodriguez

update

485. By Andres Rodriguez

Fix maas-region-udeb.postinst for better interaction

486. By Andres Rodriguez

Fix rack

487. By Andres Rodriguez

fixed

488. By Andres Rodriguez

fix

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Considering this code doesn't have to do much more than set a username/password or URLs and such, you could have done it with a single udeb which asks the question whether you want to install a region controller or rack controller (the question would be preseeded for the purpose of the Server CD anyway). That said, the approach to take is yours to choose.

I'm a little concerned with the pkgsel and tasksel usage though, as I can see this would likely override other preseeding set by the user, which may not be what you want:
+db_set pkgsel/include maas
+set_question tasksel tasksel/first multiselect "standard, server"

This will override pkgsel/include, so you may wish to db_get it first and merge the changes in (no deduplication needed), and the same applies to tasksel/first.

review: Needs Fixing
Revision history for this message
LaMont Jones (lamont) wrote :

Just one comment (I'll let you check into what the XC- tells the packager to do...) Looks good otherwise, nothing screams at me. If it works, call it good.

review: Approve
Revision history for this message
LaMont Jones (lamont) wrote :

> Considering this code doesn't have to do much more than set a
> username/password or URLs and such, you could have done it with a single udeb
> which asks the question whether you want to install a region controller or
> rack controller (the question would be preseeded for the purpose of the Server
> CD anyway). That said, the approach to take is yours to choose.
>
> I'm a little concerned with the pkgsel and tasksel usage though, as I can see
> this would likely override other preseeding set by the user, which may not be
> what you want:
> +db_set pkgsel/include maas
> +set_question tasksel tasksel/first multiselect "standard, server"
>
> This will override pkgsel/include, so you may wish to db_get it first and
> merge the changes in (no deduplication needed), and the same applies to
> tasksel/first.

Good points.

489. By Andres Rodriguez

remove unneeded comment

490. By Andres Rodriguez

Fix lamon'ts comments

Revision history for this message
Andres Rodriguez (andreserl) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: