Merge lp://qastaging/~andreserl/maas/lp1561954 into lp://qastaging/~maas-maintainers/maas/packaging
Proposed by
Andres Rodriguez
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Andres Rodriguez | ||||||||
Approved revision: | 490 | ||||||||
Merged at revision: | 478 | ||||||||
Proposed branch: | lp://qastaging/~andreserl/maas/lp1561954 | ||||||||
Merge into: | lp://qastaging/~maas-maintainers/maas/packaging | ||||||||
Diff against target: |
412 lines (+298/-22) 10 files modified
debian/changelog (+6/-2) debian/control (+23/-3) debian/maas-common.templates (+34/-1) debian/maas-rack-controller.postinst (+1/-0) debian/maas-rack-controller.templates (+0/-16) debian/maas-rack-udeb.postinst (+77/-0) debian/maas-rack-udeb.templates (+36/-0) debian/maas-region-controller.postinst (+10/-0) debian/maas-region-udeb.postinst (+82/-0) debian/maas-region-udeb.templates (+29/-0) |
||||||||
To merge this branch: | bzr merge lp://qastaging/~andreserl/maas/lp1561954 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andres Rodriguez (community) | Approve | ||
LaMont Jones (community) | Approve | ||
Mathieu Trudel-Lapierre (community) | Needs Fixing | ||
Review via email:
|
Commit message
Add maas-region-udeb and maas-rack-udeb to be used as part of the Ubuntu Server Installer (LP: #1561954)
To post a comment you must log in.
Considering this code doesn't have to do much more than set a username/password or URLs and such, you could have done it with a single udeb which asks the question whether you want to install a region controller or rack controller (the question would be preseeded for the purpose of the Server CD anyway). That said, the approach to take is yours to choose.
I'm a little concerned with the pkgsel and tasksel usage though, as I can see this would likely override other preseeding set by the user, which may not be what you want:
+db_set pkgsel/include maas
+set_question tasksel tasksel/first multiselect "standard, server"
This will override pkgsel/include, so you may wish to db_get it first and merge the changes in (no deduplication needed), and the same applies to tasksel/first.