Merge lp://qastaging/~andrewsomething/ubuntu/precise/compizconfig-settings-manager/disable_unity_checkbox into lp://qastaging/ubuntu/precise/compizconfig-settings-manager

I have upload rights for this package, but I'd appreciate a code review.

Looks good! Thanks for your work here :)

If I were you, I would try that code to make something a little bit more beautiful:
backlist_plugins = ['core']
if os.getenv('DESKTOP_SESSION') == "ubuntu":
    backlist_plugin.append('unityshell')

if plugin.Name not in backlist_plugins:
  … keep there the other code.

That would end in a way smaller diff, wdyt?
Oh btw, the packaging branch for ccsm is https://code.launchpad.net/~compiz/compizconfig-settings-manager/ubuntu as pointed by vcs-bzr, can you please propose a merge here and subscribe me?

Thanks a lot :)

On Mon, Feb 13, 2012 at 10:47 AM, Didier Roche <email address hidden> wrote:
> Review: Needs Fixing
>
> Looks good! Thanks for your work here :)
>
> If I were you, I would try that code to make something a little bit more beautiful:
> backlist_plugins = ['core']
> if os.getenv('DESKTOP_SESSION') == "ubuntu":
>    backlist_plugin.append('unityshell')
>
> if plugin.Name not in backlist_plugins:
>  … keep there the other code.
>
> That would end in a way smaller diff, wdyt?

That is much nicer. =)

> Oh btw, the packaging branch for ccsm is https://code.launchpad.net/~compiz/compizconfig-settings-manager/ubuntu as pointed by vcs-bzr, can you please propose a merge here and subscribe me?

Re-targeting both merge proposals.

Thanks,

-- Andrew Starr-Bochicchio

   Ubuntu Developer <https://launchpad.net/~andrewsomething>
   Debian Maintainer
<http://qa.debian.org/developer.php?login=a.starr.b%40gmail.com>
   PGP/GPG Key ID: D53FDCB1