Launchpad itself

Merge ~andrey-fedoseev/launchpad:db-bug-presence into launchpad:db-devel

Proposed by Andrey Fedoseev on 2022-10-18

Status:	Needs review
Proposed branch:	~andrey-fedoseev/launchpad:db-bug-presence
Merge into:	launchpad:db-devel
Diff against target:	88 lines (+71/-0) 2 files modified database/schema/patch-2211-12-0.sql (+70/-0) database/schema/security.cfg (+1/-0)
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Colin Watson (community)	db	2022-10-18	Approve on 2022-11-28
William Grant	db	2022-11-28	Pending
Review via email: mp+431711@code.qastaging.launchpad.net

Commit message

Add `BugPresence` table

Description of the change

It represents a range of versions or git commits in which the bug was present.

Revision history for this message

Colin Watson (cjwatson) wrote on 2022-10-20:

I haven't fully thought through all of this, and as discussed today there are some details around this that I want to discuss with stakeholders next week, but here's a first-pass review with some issues I noticed that you should be able to clean up in the meantime.

review: Needs Fixing (db)

Revision history for this message

Andrey Fedoseev (andrey-fedoseev) wrote on 2022-11-21:

Colin,

I've made the requested changes here and updated the code branch accordingly https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/431710:

- git commit fields are set to be exactly 40 chars long
- remove ON DELETE CASCADE from the bug presence table; when a git repository is removed the related bug presence instances are removed via `destroySelf`
- distribution is no longer a valid target for bug presence; a target can be either: git repo, project, source package name or distribution package; I'm not sure about "source package name" being a target, let me know it this needs to be changed.