Merge lp://qastaging/~angeloc/ubuntu-community-accomplishments/fix-for-scripts into lp://qastaging/~ubuntu-community-accomplishments-reviewers/ubuntu-community-accomplishments/0.1

Hi Angelo,

I am not sure what this merge proposal is doing. From what I can tell everything is working great with the First Bazaar Branch merged. Can you explain what your contribution here does?

Thanks!

Hi Jono,

I'll explain with an example (comments are inline with code):

Opening registered-on-launchpad.py I can see:

----
import traceback, sys

from accomplishments.daemon import dbusapi

try:
    # wrong: sys double import, previously imported at the top
    # wrong: modules os, pwd, subprocess never used
    import sys, os, pwd, subprocess
    # should be at the top
    from launchpadlib.launchpad import Launchpad
---

I made this chages in each file that had a problem.

Hope this helps!

2012/4/28 Jono Bacon <email address hidden>

> Review: Needs Information
>
> Hi Angelo,
>
> I am not sure what this merge proposal is doing. From what I can tell
> everything is working great with the First Bazaar Branch merged. Can you
> explain what your contribution here does?
>
> Thanks!
> --
>
> https://code.launchpad.net/~angeloc/ubuntu-community-accomplishments/fix-for-scripts/+merge/103894
> You are the owner of
> lp:~angeloc/ubuntu-community-accomplishments/fix-for-scripts.
>

--
Profile: http://it.linkedin.com/in/compagnucciangelo

Thanks, Angelo! I have to run out now, but I will take a look at this when I get back. Thanks! :-)

Thanks for your contributions here, Angelo!

Everything here worked great apart from one issue when running registered-on-launchpad.py:

Traceback (most recent call last):
  File "registered-on-launchpad.py", line 5, in <module>
    from launchpadlib.launchpad import Launchpadbzr
ImportError: cannot import name Launchpadbzr

should that line be:

    from launchpadlib.launchpad import Launchpadbzr

Thanks!

Done,

It was the bzr command that slipped into the wrong windows right before the
commit and after the tests. Re-tested all the script, now they are working.

Thanks.

2012/5/4 Jono Bacon <email address hidden>

> Review: Needs Fixing
>
> Thanks for your contributions here, Angelo!
>
> Everything here worked great apart from one issue when running
> registered-on-launchpad.py:
>
> Traceback (most recent call last):
> File "registered-on-launchpad.py", line 5, in <module>
> from launchpadlib.launchpad import Launchpadbzr
> ImportError: cannot import name Launchpadbzr
>
> should that line be:
>
> from launchpadlib.launchpad import Launchpadbzr
>
> Thanks!
> --
>
> https://code.launchpad.net/~angeloc/ubuntu-community-accomplishments/fix-for-scripts/+merge/103894
> You are the owner of
> lp:~angeloc/ubuntu-community-accomplishments/fix-for-scripts.
>

--
Profile: http://it.linkedin.com/in/compagnucciangelo

Thanks, Angelo! Merged! :-)