Unity

Merge lp://qastaging/~apinheiro/unity/Bug705442 into lp://qastaging/unity

  1. Bug705442
  2. Merge into trunk
Proposed by Alejandro Piñeiro
Status: Merged
Merge reported by: Alex Launi
Merged at revision: not available
Proposed branch: lp://qastaging/~apinheiro/unity/Bug705442
Merge into: lp://qastaging/unity
Diff against target: 0 lines
To merge this branch: bzr merge lp://qastaging/~apinheiro/unity/Bug705442
Reviewer Review Type Date Requested Status
Loïc Molinari (community) Approve
Review via email: mp+47846@code.qastaging.launchpad.net

Description of the change

Although the bug was closed and this branch already merged, today I was checking the code, and the changes related to this changes are not on the unity branch.

So Im proposing again merging it.

To post a comment you must log in.
Revision history for this message
Loïc Molinari (loic.molinari) wrote :

Alejandro: I reverted the change fixing the main reason this critical assertion was emitted [1]. Tell me if it's ok for you and if the merge still makes sense.

[1] http://bazaar.launchpad.net/~unity-team/unity/trunk/revision/790

Revision history for this message
Loïc Molinari (loic.molinari) wrote :

ok, so after having discussed the issue with Alejandro on IRC, both patches make sense. The former is mandatory because a11y could actually be disabled as a system setting, and the latter fixes a critical assertion.

Revision history for this message
Alejandro Piñeiro (apinheiro) wrote :

I added you are reviewer, just because it was not clear who will re-merge this branch. Should I do that or will you do that?

Revision history for this message
Loïc Molinari (loic.molinari) wrote :

I've just re-merged it.

review: Approve

Preview Diff

Empty