Merge lp://qastaging/~apinheiro/unity/Bug817477 into lp://qastaging/unity

Proposed by Alejandro Piñeiro
Status: Merged
Merged at revision: 1493
Proposed branch: lp://qastaging/~apinheiro/unity/Bug817477
Merge into: lp://qastaging/unity
Diff against target: 103 lines (+46/-12)
2 files modified
services/panel-indicator-accessible.c (+40/-10)
services/panel-indicator-entry-accessible.c (+6/-2)
To merge this branch: bzr merge lp://qastaging/~apinheiro/unity/Bug817477
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Alex Launi Pending
Review via email: mp+73835@code.qastaging.launchpad.net

Description of the change

In the end the solution was one line. panel_indicator_entry_accessible_ref_child is a implementation of atk_object_ref_child, and as the name implies, it supposes that a reference count is required.

This branch also some NULL check conditions that I started to add while triagging the bug. It is really tied to this and I really think that doesn't hurt. Anyway if you prefer just add that g_object_ref I'm ok to add a new bug

To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks good to me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.